allow calling [github] without auth #9427
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chris48s
added
the
service-badge
chris48s
commented
Jul 31, 2023
| ...{ | ||
| url, | ||
| query, | ||
| httpErrorMessages: { 401: 'auth required for graphql api' }, |
There was a problem hiding this comment.
The v4/GraphQL API doesn't allow anonymous access - a token is required
| @@ -49,7 +49,11 @@ export default class GithubSearch extends GithubAuthV3Service { | |||
| }, | |||
| }, | |||
| schema, | |||
| httpErrors: httpErrorsFor('repo not found'), | |||
| httpErrors: { | |||
| 401: 'auth required for search api', | |||
There was a problem hiding this comment.
The search API doesn't allow anonymous access - a token is required
| '/repos/rust-lang/rust', | ||
| {}, | ||
| ) | ||
| expect(res.statusCode).to.equal(200) |
There was a problem hiding this comment.
When I was working on this, I realised this test never actually asserted the calls were successful! 😬
chris48s
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2754
Refs #9386 (comment)
This PR resolves a long-standing issue that even though GitHub allows anonymous access to the v3 API with a reasonable rate limit, you have to set a key locally to do any development on any GitHub badges. The changes in #9386 make it extra desirable to be able to call the GH API without auth if possible.
I've set this PR to run the github test suite. Five of them will fail, but I submitted another PR to fix the tests at #9425 so we could merge that first then rebase this onto it, although I think the integration tests are actually the critical ones here.