forked from ray-project/ray
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Avoid shell escaping command_prefix
#10
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Noticed this issue with out multi-node setup:
It appears that we quoted too much of the command in #8 |
This was referenced Sep 18, 2023
kleinschmidt
approved these changes
Sep 20, 2023
glennmoy
pushed a commit
that referenced
this pull request
Sep 26, 2023
glennmoy
pushed a commit
that referenced
this pull request
Sep 26, 2023
glennmoy
pushed a commit
that referenced
this pull request
Sep 26, 2023
glennmoy
pushed a commit
that referenced
this pull request
Sep 26, 2023
glennmoy
pushed a commit
that referenced
this pull request
Sep 26, 2023
glennmoy
pushed a commit
that referenced
this pull request
Sep 27, 2023
glennmoy
pushed a commit
that referenced
this pull request
Sep 27, 2023
glennmoy
pushed a commit
that referenced
this pull request
Sep 27, 2023
glennmoy
pushed a commit
that referenced
this pull request
Oct 27, 2023
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Probably will end up being a dumping ground for various small changes to support multi-node clustersUpdate: Was the only required backend change to get multi-node support working.