Runtime environment can specify Julia executable and arguments #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
| # this information would be passed in via the serialized runtime | ||
| # context. | ||
| executable = self.executable or "julia" | ||
| args = self.args or ["-e", "'using Ray; start_worker()'"] |
There was a problem hiding this comment.
do we ever NOT want to do this? would it make more sense to allow users to pass extra arguments that are added in addition to these defaults?
There was a problem hiding this comment.
ah I see, that's passthrough_args
There was a problem hiding this comment.
We can definitely drop the fallback but we probably want to keep it at least temporarily as otherwise we'll break Ray.jl CI when this is merged and beacon-biosignals/Ray.jl#103 has not yet been merged
kleinschmidt
approved these changes
Sep 14, 2023
Co-authored-by: Dave Kleinschmidt <dave.f.kleinschmidt@gmail.com> Signed-off-by: Curtis Vogt <curtis.vogt@gmail.com>
|
This was referenced Sep 14, 2023
glennmoy
pushed a commit
that referenced
this pull request
Sep 26, 2023
* Support specifying runtime env executable * Support specifying runtime env args * Support specifying executable/args via runtime env * Avoid quoting default * Switch to using command in RuntimeEnvContext * Use separate command for Julia * Add TODO about switching to plugin Co-authored-by: Dave Kleinschmidt <dave.f.kleinschmidt@gmail.com> Signed-off-by: Curtis Vogt <curtis.vogt@gmail.com> --------- Signed-off-by: Curtis Vogt <curtis.vogt@gmail.com> Co-authored-by: Dave Kleinschmidt <dave.f.kleinschmidt@gmail.com>
glennmoy
pushed a commit
that referenced
this pull request
Sep 26, 2023
* Support specifying runtime env executable * Support specifying runtime env args * Support specifying executable/args via runtime env * Avoid quoting default * Switch to using command in RuntimeEnvContext * Use separate command for Julia * Add TODO about switching to plugin Co-authored-by: Dave Kleinschmidt <dave.f.kleinschmidt@gmail.com> Signed-off-by: Curtis Vogt <curtis.vogt@gmail.com> --------- Signed-off-by: Curtis Vogt <curtis.vogt@gmail.com> Co-authored-by: Dave Kleinschmidt <dave.f.kleinschmidt@gmail.com>
glennmoy
pushed a commit
that referenced
this pull request
Sep 26, 2023
* Support specifying runtime env executable * Support specifying runtime env args * Support specifying executable/args via runtime env * Avoid quoting default * Switch to using command in RuntimeEnvContext * Use separate command for Julia * Add TODO about switching to plugin Co-authored-by: Dave Kleinschmidt <dave.f.kleinschmidt@gmail.com> Signed-off-by: Curtis Vogt <curtis.vogt@gmail.com> --------- Signed-off-by: Curtis Vogt <curtis.vogt@gmail.com> Co-authored-by: Dave Kleinschmidt <dave.f.kleinschmidt@gmail.com>
glennmoy
pushed a commit
that referenced
this pull request
Sep 26, 2023
* Support specifying runtime env executable * Support specifying runtime env args * Support specifying executable/args via runtime env * Avoid quoting default * Switch to using command in RuntimeEnvContext * Use separate command for Julia * Add TODO about switching to plugin Co-authored-by: Dave Kleinschmidt <dave.f.kleinschmidt@gmail.com> Signed-off-by: Curtis Vogt <curtis.vogt@gmail.com> --------- Signed-off-by: Curtis Vogt <curtis.vogt@gmail.com> Co-authored-by: Dave Kleinschmidt <dave.f.kleinschmidt@gmail.com>
glennmoy
pushed a commit
that referenced
this pull request
Sep 26, 2023
* Support specifying runtime env executable * Support specifying runtime env args * Support specifying executable/args via runtime env * Avoid quoting default * Switch to using command in RuntimeEnvContext * Use separate command for Julia * Add TODO about switching to plugin Co-authored-by: Dave Kleinschmidt <dave.f.kleinschmidt@gmail.com> Signed-off-by: Curtis Vogt <curtis.vogt@gmail.com> --------- Signed-off-by: Curtis Vogt <curtis.vogt@gmail.com> Co-authored-by: Dave Kleinschmidt <dave.f.kleinschmidt@gmail.com>
glennmoy
pushed a commit
that referenced
this pull request
Sep 27, 2023
* Support specifying runtime env executable * Support specifying runtime env args * Support specifying executable/args via runtime env * Avoid quoting default * Switch to using command in RuntimeEnvContext * Use separate command for Julia * Add TODO about switching to plugin Co-authored-by: Dave Kleinschmidt <dave.f.kleinschmidt@gmail.com> Signed-off-by: Curtis Vogt <curtis.vogt@gmail.com> --------- Signed-off-by: Curtis Vogt <curtis.vogt@gmail.com> Co-authored-by: Dave Kleinschmidt <dave.f.kleinschmidt@gmail.com>
glennmoy
pushed a commit
that referenced
this pull request
Sep 27, 2023
* Support specifying runtime env executable * Support specifying runtime env args * Support specifying executable/args via runtime env * Avoid quoting default * Switch to using command in RuntimeEnvContext * Use separate command for Julia * Add TODO about switching to plugin Co-authored-by: Dave Kleinschmidt <dave.f.kleinschmidt@gmail.com> Signed-off-by: Curtis Vogt <curtis.vogt@gmail.com> --------- Signed-off-by: Curtis Vogt <curtis.vogt@gmail.com> Co-authored-by: Dave Kleinschmidt <dave.f.kleinschmidt@gmail.com>
glennmoy
pushed a commit
that referenced
this pull request
Sep 27, 2023
* Support specifying runtime env executable * Support specifying runtime env args * Support specifying executable/args via runtime env * Avoid quoting default * Switch to using command in RuntimeEnvContext * Use separate command for Julia * Add TODO about switching to plugin Co-authored-by: Dave Kleinschmidt <dave.f.kleinschmidt@gmail.com> Signed-off-by: Curtis Vogt <curtis.vogt@gmail.com> --------- Signed-off-by: Curtis Vogt <curtis.vogt@gmail.com> Co-authored-by: Dave Kleinschmidt <dave.f.kleinschmidt@gmail.com>
glennmoy
pushed a commit
that referenced
this pull request
Oct 27, 2023
* Support specifying runtime env executable * Support specifying runtime env args * Support specifying executable/args via runtime env * Avoid quoting default * Switch to using command in RuntimeEnvContext * Use separate command for Julia * Add TODO about switching to plugin Co-authored-by: Dave Kleinschmidt <dave.f.kleinschmidt@gmail.com> Signed-off-by: Curtis Vogt <curtis.vogt@gmail.com> --------- Signed-off-by: Curtis Vogt <curtis.vogt@gmail.com> Co-authored-by: Dave Kleinschmidt <dave.f.kleinschmidt@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Working on beacon-biosignals/Ray.jl#103.
Something tricky about getting this to work was that I found that my
serialized_runtime_envwas set properly here but the RPC reply later had filtered out my new parameters. I wasn't sure where this was being processed so I removedenv_varsfrom theRuntimeEnvContextand got a stack trace which pointed me to the dashboard code. It turns out that you need to pass through any runtime environment information here or it will be expected to be processed by a plugin. If no plugin is associated with the key then the value is just set to the default inRuntimeEnvContext.