Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] test dev server on Windows #1546

Merged
merged 16 commits into from
Apr 6, 2021
Merged

[CI] test dev server on Windows #1546

merged 16 commits into from
Apr 6, 2021

Conversation

bojiang
Copy link
Member

@bojiang bojiang commented Mar 30, 2021

Description

Until now integration tests in CI only cover the production server on POSIX platforms.
This change covers the development server (bentoml serve) on Windows #1544

Motivation and Context

How Has This Been Tested?

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature and improvements (non-breaking change which adds/improves functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Code Refactoring (internal change which is not user facing)
  • Documentation
  • Test, CI, or build

Component(s) if applicable

  • BentoService (service definition, dependency management, API input/output adapters)
  • Model Artifact (model serialization, multi-framework support)
  • Model Server (mico-batching, dockerisation, logging, OpenAPI, instruments)
  • YataiService gRPC server (model registry, cloud deployment automation)
  • YataiService web server (nodejs HTTP server and web UI)
  • Internal (BentoML's own configuration, logging, utility, exception handling)
  • BentoML CLI

Checklist:

  • My code follows the bentoml code style, both ./dev/format.sh and
    ./dev/lint.sh script have passed
    (instructions).
  • My change reduces project test coverage and requires unit tests to be added
  • I have added unit tests covering my code change
  • My change requires a change to the documentation
  • I have updated the documentation accordingly

@bojiang bojiang changed the title Ci itest win [CI] test dev server on Windows Mar 30, 2021
@bojiang bojiang linked an issue Mar 30, 2021 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Mar 30, 2021

Codecov Report

Merging #1546 (43d6c0d) into master (3586317) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1546   +/-   ##
=======================================
  Coverage   68.62%   68.62%           
=======================================
  Files         153      153           
  Lines       10215    10215           
=======================================
  Hits         7010     7010           
  Misses       3205     3205           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3586317...43d6c0d. Read the comment docs.

@parano parano merged commit 78ef467 into bentoml:master Apr 6, 2021
@bojiang bojiang deleted the ci-itest-win branch April 7, 2021 01:47
@parano parano mentioned this pull request Apr 11, 2021
18 tasks
aarnphm pushed a commit to aarnphm/BentoML that referenced this pull request Jul 29, 2022
* Enable itest for Windows

* run itest with the dev server

* fix workers

* minor fix

* fix

* timeout

* fix for win

* ?

* fix

* fix

* fix

* skip performance tests on Windows

* make pylint happy

* make pylint happy

* fix

* fix windows path
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AttributeError: module 'aiohttp' has no attribute 'web'
2 participants