-
Notifications
You must be signed in to change notification settings - Fork 779
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CI] test dev server on Windows #1546
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1546 +/- ##
=======================================
Coverage 68.62% 68.62%
=======================================
Files 153 153
Lines 10215 10215
=======================================
Hits 7010 7010
Misses 3205 3205 Continue to review full report at Codecov.
|
18 tasks
aarnphm
pushed a commit
to aarnphm/BentoML
that referenced
this pull request
Jul 29, 2022
* Enable itest for Windows * run itest with the dev server * fix workers * minor fix * fix * timeout * fix for win * ? * fix * fix * fix * skip performance tests on Windows * make pylint happy * make pylint happy * fix * fix windows path
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Until now integration tests in CI only cover the production server on POSIX platforms.
This change covers the development server (
bentoml serve
) on Windows #1544Motivation and Context
How Has This Been Tested?
Types of changes
Component(s) if applicable
Checklist:
./dev/format.sh
and./dev/lint.sh
script have passed(instructions).