Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix aiohttp importing for Windows #1557

Merged
merged 1 commit into from
Mar 31, 2021
Merged

Fix aiohttp importing for Windows #1557

merged 1 commit into from
Mar 31, 2021

Conversation

bojiang
Copy link
Member

@bojiang bojiang commented Mar 31, 2021

Description

Todo: enable integration tests for the development server on Windows(#1546) to avoid breaks in the future.

Motivation and Context

How Has This Been Tested?

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature and improvements (non-breaking change which adds/improves functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Code Refactoring (internal change which is not user facing)
  • Documentation
  • Test, CI, or build

Component(s) if applicable

  • BentoService (service definition, dependency management, API input/output adapters)
  • Model Artifact (model serialization, multi-framework support)
  • Model Server (mico-batching, dockerisation, logging, OpenAPI, instruments)
  • YataiService gRPC server (model registry, cloud deployment automation)
  • YataiService web server (nodejs HTTP server and web UI)
  • Internal (BentoML's own configuration, logging, utility, exception handling)
  • BentoML CLI

Checklist:

  • My code follows the bentoml code style, both ./dev/format.sh and
    ./dev/lint.sh script have passed
    (instructions).
  • My change reduces project test coverage and requires unit tests to be added
  • I have added unit tests covering my code change
  • My change requires a change to the documentation
  • I have updated the documentation accordingly

@bojiang bojiang linked an issue Mar 31, 2021 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Mar 31, 2021

Codecov Report

Merging #1557 (58ae641) into master (ebe69b0) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1557      +/-   ##
==========================================
- Coverage   69.14%   69.13%   -0.02%     
==========================================
  Files         152      152              
  Lines       10188    10189       +1     
==========================================
- Hits         7045     7044       -1     
- Misses       3143     3145       +2     
Impacted Files Coverage Δ
bentoml/marshal/marshal.py 72.51% <100.00%> (-1.02%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4fe5089...58ae641. Read the comment docs.

@parano parano merged commit 8a6d4a3 into bentoml:master Mar 31, 2021
@bnapora
Copy link

bnapora commented Mar 31, 2021

Great. Will 0.12.1 be available on pypi or just from source?

@parano
Copy link
Member

parano commented Apr 1, 2021

@bnapora it will be released on PyPI soon, you may watch the repo to subscribe to new release notifications

aarnphm pushed a commit to aarnphm/BentoML that referenced this pull request Jul 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AttributeError: module 'aiohttp' has no attribute 'web'
3 participants