Skip to content

Commit

Permalink
msrv: only send a message on failure during the actual msrv part (#7532)
Browse files Browse the repository at this point in the history
# Objective

- In case of a CI failure before the MSRV check, like installing linux dependencies, a comment was still added to the PR

## Solution

- Check that the actual MSRV step failed
  • Loading branch information
mockersf committed Feb 6, 2023
1 parent 2e20d04 commit 0cbb9f7
Showing 1 changed file with 3 additions and 2 deletions.
5 changes: 3 additions & 2 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -332,14 +332,15 @@ jobs:
- name: Install alsa and udev
run: sudo apt-get update; sudo apt-get install --no-install-recommends libasound2-dev libudev-dev
- name: Run cargo check
id: check
run: cargo check
- name: Save PR number
if: ${{ failure() && github.event_name == 'pull_request' }}
if: ${{ failure() && github.event_name == 'pull_request' && steps.check.conclusion == 'failure' }}
run: |
mkdir -p ./msrv
echo ${{ github.event.number }} > ./msrv/NR
- uses: actions/upload-artifact@v2
if: ${{ failure() && github.event_name == 'pull_request' }}
if: ${{ failure() && github.event_name == 'pull_request' && steps.check.conclusion == 'failure' }}
with:
name: msrv
path: msrv/

0 comments on commit 0cbb9f7

Please sign in to comment.