Make docs consistent re: default/min parameters #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'd commented out the ground-truth checking code (due to the randomness of the test inputs), so the docstring that said the test checked against ground truths ended up being inaccurate. (My b)
It looked like there were a few inconsistencies. Nothing major (if the user passed in something with --rank 1 / --n_components 1 then they should just get an error) but probably worth addressing at some time
cameronmartino
approved these changes
Jul 11, 2019
|
Added another commit that shills Qurro's moving pictures tutorial, now that that's ready :P |
|
@fedarko this looks okay to merge. thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think there might still need to be some changes made regarding parameter names (since it looks like
--rankhas been changed to--n_components, and--iterationshas been changed to--max_iterations), but I'm not sure what to do there.this is a low priority fix so no worries :)