Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Store count data outside of plot JSONs #102

Closed
fedarko opened this issue May 6, 2019 · 1 comment
Closed

Store count data outside of plot JSONs #102

fedarko opened this issue May 6, 2019 · 1 comment
Assignees
Labels
optimization Making code faster or cleaner

Comments

@fedarko
Copy link
Collaborator

fedarko commented May 6, 2019

I think this should make the plots load a ton faster, as well as stave off crashing when you try to open the vega editor for the sample plot. (It's not like you can recompute log ratios within the Vega Editor, so there isn't any sense storing the count data inside the sample plot.)

This shouldn't require a ton of coding work. Just:

  • change up the python script to output the count data to a separate variable from the sample plot
  • change up the python testing utilities to get count data from that variable instead
  • change up the JS to take the count data as an RRVDisplay parameter, and set this.feature_cts according to that
  • change up the JS tests to set the count data accordingly as well
@fedarko fedarko added the optimization Making code faster or cleaner label May 6, 2019
@fedarko fedarko self-assigned this May 6, 2019
@fedarko
Copy link
Collaborator Author

fedarko commented May 7, 2019

We might be able to take this a step farther, and actually load the count data (and compute log ratios, or just get the desired counts) entirely in a web worker. This would prevent the costs of loading that into memory from hitting the page, ideally.

fedarko added a commit that referenced this issue May 13, 2019
ENH: Store count data in separate JSON: close #102
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
optimization Making code faster or cleaner
Projects
None yet
Development

No branches or pull requests

1 participant