Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Host this on PyPI and conda-forge #153

Closed
2 of 3 tasks
fedarko opened this issue Jun 3, 2019 · 5 comments
Closed
2 of 3 tasks

Host this on PyPI and conda-forge #153

fedarko opened this issue Jun 3, 2019 · 5 comments
Assignees
Labels
administrative Logistical matters that don't have much or anything to do with code important Things that are critical for getting Qurro in a working/useful state
Milestone

Comments

@fedarko
Copy link
Collaborator

fedarko commented Jun 3, 2019

IMO this is dependent on #92 and #85 being addressed satisfactorily. Should be doable soon.

  • Host on PyPI
  • Host on conda-forge (just test that Qurro is importable)
  • Host on conda-forge (run full test suite?)

So a complication with the full-test-suite thing is that the python tests rely on Q2 being installed... that'll make life hard.

Note that per #74, these should require that the min python version is 3.5.3

@fedarko fedarko added the administrative Logistical matters that don't have much or anything to do with code label Jun 3, 2019
@fedarko fedarko self-assigned this Jun 3, 2019
@fedarko fedarko added the important Things that are critical for getting Qurro in a working/useful state label Jun 3, 2019
@fedarko
Copy link
Collaborator Author

fedarko commented Jun 25, 2019

fedarko added a commit that referenced this issue Jun 25, 2019
@fedarko
Copy link
Collaborator Author

fedarko commented Jun 28, 2019

looks like in order to do things cleanly for conda forge, it'll be easiest to make tests output to a tests/output/ directory like before and then move outputs to docs/demos. That'll make it easier to run tests in the meta.yaml.

@mortonjt
Copy link

mortonjt commented Aug 1, 2019

you don't need to have comprehensive tests run on conda-forge. A good first pass is to just make sure that qurro can be imported.

@fedarko
Copy link
Collaborator Author

fedarko commented Aug 2, 2019

i guess that's fair! i would like to run the tests if possible, just to verify that stuff isn't completely broken. but i'll see about just getting a cursory conda-forge build set up sometime in the future, maybe adding in the test suite at a later point

@fedarko fedarko added this to the Priority Tasks milestone Aug 2, 2019
@fedarko
Copy link
Collaborator Author

fedarko commented Apr 3, 2020

Update: as of today, Qurro is now on conda-forge (feedstock link). :shipit: :shipit: :shipit:

There are some issues with the build (looks like it doesn't work on python 3.8 which makes sense since iirc BIOM/etc. also explode on 3.8, so i'll need to explicitly skip that version), but this issue is basically done. (I'll close this when we merge in conda install instructions to the README.)

@fedarko fedarko modified the milestones: Priority Tasks, v0.7.0 Apr 14, 2020
@fedarko fedarko closed this as completed in c942ea4 May 4, 2020
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
administrative Logistical matters that don't have much or anything to do with code important Things that are critical for getting Qurro in a working/useful state
Projects
None yet
Development

No branches or pull requests

2 participants