Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

qurro_x isn't checked for in the feature ranks/metadata restricted fields #183

Closed
fedarko opened this issue Jul 10, 2019 · 0 comments
Closed

qurro_x isn't checked for in the feature ranks/metadata restricted fields #183

fedarko opened this issue Jul 10, 2019 · 0 comments
Assignees
@fedarko
Labels
bug Something isn't working
Milestone
Priority Tasks

Comments

@fedarko
Copy link
Collaborator

fedarko commented Jul 10, 2019

I forgot to bring it up in #55, but this is a problem (albeit a super minor one since I doubt anyone is going to have a feature ranking/metadata col with this exact name).

Should just check for this up front (maybe also check for it in the GNPS feature metadata? actually probs not needed since we only keep the LibraryID field IIRC) in check_column_names(). Add a corresponding test, of course.
@fedarko fedarko added the bug Something isn't working label Jul 10, 2019
@fedarko fedarko self-assigned this Jul 10, 2019
@fedarko fedarko added this to the v0.3.0 milestone Jul 10, 2019
fedarko added a commit to fedarko/qurro that referenced this issue Jul 15, 2019
@fedarko
REL/MAINT: Update changelog re: biocore#183+related stuff
cb99129 
Now, this checks up front if "LibraryID" is in the feature ranks DF.
(Documented that change in changelog, ofc.)
@fedarko fedarko closed this as completed in c91129f Aug 2, 2019
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fedarko fedarko

Labels
bug Something isn't working
Projects
None yet
Milestone
Priority Tasks
Development

No branches or pull requests
1 participant
@fedarko