Add "Exclude metadata fields from exported data?" option #313
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes biocore#306. still gotta add tests tho
(easier to type...)
closes biocore#306 (I already said that in an earlier commit but w/e)
Looks like the main change is on docstring indentation. I don't really care about this either way so I'm cool with going with what black says.
Should un-break the build. This is mostly done out of personal convenience, since Empress and Qurro both use global NPM packages and I don't wanna have to bother with having both versions around on my system. This is one of the cases where using global packages is a bad idea, but oh well it's been very convenient up until like right now :P Eventually it would be nice to un-pin this, but there are probably many more pressing things to worry about.
|
@cameronmartino / @gwarmstrong would one of you be free to look over this sometime this week? This PR should make the Qurro steps in the Gemelli tutorials less painful. |
fedarko
added a commit
to fedarko/qurro
that referenced
this pull request
Jul 18, 2021
(Also documented in biocore#313)
fedarko
added a commit
that referenced
this pull request
Jul 18, 2021
* Fix broken tutorial link to DEICODE Emperor biplot * STY: Rerun things with later vsn of black (Also documented in #313)
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #306, and should make merging log-ratios with sample metadata easier (as is done in the Gemelli tutorials, e.g. here).
I also fixed the build by updating
black(used to style / check python code) to the latest version. This resulted in a lot of indentation changes to the docstrings. (These can probably be ignored; all of the substantial code changes here are on the JS side of the codebase.)