Command line wrapper #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
lhannest
commented
May 1, 2018
•
lhannest
commented
- Resolves command line wrapper #10
- Developed command line wrapper in kgx/kgx.py
- Changed requirements: pandas<0.21 to resolve installation error (as suggested by pip installation fails: Double requirement given: numpy==1.12.1... pandas-dev/pandas#20723)
- Added requirement: pymongo==3.6.1 to get rid of pymongo warning.
- PandasTransformer save method now saves both edge set and node set, and collects the files into a tar file. - Updated README.md to show examples from tests - Made kgx command line wrapper print the name of the directory upon success, since the output filename is not necessarily what the user requested.
cmungall
approved these changes
May 1, 2018
There was a problem hiding this comment.
Looks great!
Why is pymongo required?
https://github.com/NCATS-Tangerine/kgx/pull/22/files#diff-b4ef698db8ca845e5845c4618278f29aR11
should click not be in requirements.txt?
- Added click to requirements.txt - Fix mistaken error message in kgx.py - Fix ziptype file extention bug in pandas_transformer.py
|
@cmungall I added pymongo just to get rid of the warning: Alternatively, we could |
- Now calling report method to print cardinality of edges and nodes
|
ah, I guess prefixcommons i bringing in cachier, and cachier brings in mongo_core, and that has the warning. we should fix prefixcommons (our code), when we fix ontobio to go from cachier to diskcache biolink/ontobio#140 cc @deepakunni3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.