-
-
Notifications
You must be signed in to change notification settings - Fork 444
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(graphql_formatter): bootstrap GraphQL formatter #3255
Conversation
Parser conformance results onjs/262
jsx/babel
symbols/microsoft
ts/babel
ts/microsoft
|
CodSpeed Performance ReportMerging #3255 will not alter performanceComparing Summary
|
302b355
to
026034f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job here! Are we ready to merge it? I haven't seen reports for concerning bugs that would require a 1.8.3 release.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems you didn't create the new crates using just new-crate
. Can you update knope.toml
to add the new crates?
45785ee
to
7a687d4
Compare
I think so. I know only some fixes for css. #3251 #3257 #3254 |
Then we should at least hide all the CLI options, so we can safely merge this PR. Or we can wait a little bit until we ship a new patch release |
7a687d4
to
099bc1e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice job! Agreed we may want to hide the CLI options until the formatter is ready, other than that, looks good 👍
2244c0b
to
7ba03b8
Compare
@ematipico Could we merge it? |
Summary
This PR bootstraps all of the infrastructure for biome_graphql_formatter, including:
Test Plan
cargo test