Replace the Get Support button with Open Trader Chat until trade period is over #4099
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
example:
|
|
@jmacxx I'm having a look at it right now. Please don't make any changes to translations except the English source file, as they are overwritten shortly before every release. |
|
@ripcurlx Ok, I have restored the language files to their original (de, es, pt, pt-br). |
ripcurlx
suggested changes
Apr 3, 2020
desktop/src/main/java/bisq/desktop/main/portfolio/pendingtrades/TradeSubView.java
Outdated
Show resolved
Hide resolved
desktop/src/main/java/bisq/desktop/main/portfolio/pendingtrades/PendingTradesView.java
Outdated
Show resolved
Hide resolved
desktop/src/main/java/bisq/desktop/main/portfolio/pendingtrades/TradeSubView.java
Outdated
Show resolved
Hide resolved
desktop/src/main/java/bisq/desktop/main/portfolio/pendingtrades/steps/TradeStepView.java
Outdated
Show resolved
Hide resolved
Showing an `Open Trader Chat` button until the trade period is over will reduce the number of unnecessary support tickets and encourage trader-to-trader dialogue. If the trade timer expires without completing the button changes (as before) to open a mediation ticket. Implementation of this feature requires the button in TradeStepView to notify its parent TradeSubView which in turn notify its parent PendingTradesView that trader chat is to be opened. Basically a callback interface is passed two levels down the GUI hierarchy. Fixes #3801
ghost
changed the title
ghost
mentioned this pull request
ghost
requested a review
from
ripcurlx
approved these changes
Apr 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Showing an
Open Trader Chatbutton until the trade period is over will reduce the number of unnecessary support tickets and encourage trader-to-trader dialogue. If the trade timer expires without completing the button changes (as before) to open a mediation ticket.Implementation of this feature requires the button in TradeStepView to notify its parent TradeSubView which in turn notify its parent PendingTradesView that trader chat is to be opened. Basically a callback interface is passed two levels down the GUI hierarchy.
Fixes #3801