Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set custom security deposit when cloning an offer #5542

Merged

Conversation

ripcurlx
Copy link
Contributor

I tried to re-produce the issues mentioned by @BtcContributor, but wasn't able to do so.

Bildschirmfoto 2021-05-31 um 10 25 36
Bildschirmfoto 2021-05-31 um 10 25 32
Bildschirmfoto 2021-05-31 um 10 25 23
Bildschirmfoto 2021-05-31 um 10 25 19

@ripcurlx
Copy link
Contributor Author

@BtcContributor Could you please give it a try again, as I wasn't able to re-produce the issue you found.

@ripcurlx ripcurlx added this to the v1.6.6 milestone May 31, 2021
@ghost
Copy link

ghost commented May 31, 2021

Tested, ACK.

@BtcContributor
Copy link
Contributor

After seeing that also @jmacxx was not seeing any problem I tested again by deleting my app data folder.
In this case I can confirm that everything works as expected.

Honestly not sure why...

@ripcurlx
Copy link
Contributor Author

After seeing that also @jmacxx was not seeing any problem I tested again by deleting my app data folder.
In this case I can confirm that everything works as expected.

Honestly not sure why...

That is really pretty weird behavior 🤔

Let's keep an eye on this issue during the testing time on master until the next release.

@ripcurlx ripcurlx marked this pull request as ready for review May 31, 2021 18:40
@sqrrm sqrrm merged commit a181b48 into bisq-network:master Jun 2, 2021
@ripcurlx ripcurlx deleted the set-deposit-after-offer-duplication branch July 16, 2021 07:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants