Remind user when their DAO state needs to be refreshed #5552
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jmacxx Maybe we could make it even easier if we offer the user a button to jump directly to the DAO -> Network Monitor screen in the popup as well. WDYT? |
@ripcurlx I did the needful, looks better. Further testing revealed a bug, which has also been resolved. 😅 |
This was referenced Jul 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As described in #5393, having a DAO state that is in conflict can cause issues and unnecessary mediation cases.
Unfortunately, users are not notified when their DAO state is in conflict with seednodes, it is only shown by checking DAO -> Network Monitor -> Dao State.
This PR attempts to rectify that by checking the DAO state whenever Bisq has completed the block sync. If the DAO is reporting a conflict then a popup will be shown to the user asking them to resync . To avoid annoyance, this popup will only be shown at most once per session (and then only if a resync is needed).
This PR only checks the overall DAO state, not the voting or proposals state. This is intentional, since proposal and voting states are only applicable to a small subset of users whereas the goal of this PR is to prevent problems in trading.
Screenshot
Fixes #5329
Fixes #5393