feat/use npm registry #2
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blakef
force-pushed
the
feat/use-npm-registry
branch
from
df0647c
to
a5cfebe
Compare
blakef
force-pushed
the
feat/use-npm-registry
branch
from
7eaeb5e
to
800ccc2
Compare
When we trigger a release of the template, we capture the version of react-native it's built with in the scripts.version field. This is accessible for all version of the template. We use this store from the CLI to figure out which template to install from when running `init`. Why? This means that we can effectively decouple our package version from the react-native package version. The 1:1 version mapping was done as a stop-gap in the 0.74 release, because of problems with release candiates and semver ordering. E.g. 0.75.0, 0.75.0-rc1, 0.75.0-rc2, etc... don't order sanely. What does this do? For example, if we discover a bug in the template for 0.75.0, previously we'd have to: - get react-native to run another release (very expensive), or - change the init logic (see 0.75.0-rc1.1 as an example). Now we just release another version of the template with the fix. As long as react-native@0.75.0 is still set as the version, the cli will pick the latest published version of the template with a matching version. See the commit for more details about exactly how version are picked. [0] https://github.com/react-native-community/template/blob/main/scripts/updateReactNativeVersion.js#L66-L93
blakef
force-pushed
the
feat/use-npm-registry
branch
from
800ccc2
to
096dfc2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
--pmoption to specify package manager (docs: update init.md react-native-community/cli#2426)getCommandOutputexec thread react-native-community/cli#2414)-ialias for--interactiveoption (feat: add-ialias for--interactiveoption react-native-community/cli#2420)wspackage which patches a security vulnerability (chore: bumpswspackage which patches a security vulnerability react-native-community/cli#2431)actionorcategory(fix: skip if there's noactionorcategoryreact-native-community/cli#2432)rootproperty should use__dirname(docs: note thatrootproperty should use__dirnamereact-native-community/cli#2433)envinfopackage (chore: bumpenvinfopackage react-native-community/cli#2428)node_modulesas last item (fix(clean): make sure to deletenode_modulesas last item react-native-community/cli#2429)ENOWORKSPACESwhen running any command on latest npm (fix(cli): fixENOWORKSPACESwhen running any command on latest npm react-native-community/cli#2457)--versionoption (feat: add--versionoption react-native-community/cli#2460)