Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: improve error message when cannot find Xcode project #2444

Merged
merged 1 commit into from
Jul 3, 2024
Merged

feat: improve error message when cannot find Xcode project #2444

merged 1 commit into from
Jul 3, 2024

Conversation

szymonrybczak
Copy link
Collaborator

@szymonrybczak szymonrybczak commented Jul 3, 2024 •
edited
Loading

Summary:

Guides user to maybe install Cocoapods when Xcode project is not available (there are some project when running pod install generates projects).

Test Plan:

  1. Clone the repository and do all the required steps from the Contributing guide
  2. Create a project with npx --package react-native-test-app@latest init
  3. Run yarn react-native run-ios.

Checklist

  • Documentation is up to date to reflect these changes.
  • Follows commit message convention described in CONTRIBUTING.md

thymikee
thymikee approved these changes Jul 3, 2024
View reviewed changes
Copy link
Member

@thymikee thymikee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good one

@szymonrybczak szymonrybczak merged commit 98375b7 into main Jul 3, 2024
8 of 10 checks passed
@szymonrybczak szymonrybczak deleted the feat/improve-error-message branch July 3, 2024 20:42
@blakef blakef mentioned this pull request Aug 16, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thymikee thymikee thymikee approved these changes

@cipolleschi cipolleschi Awaiting requested review from cipolleschi cipolleschi is a code owner

@adamTrz adamTrz Awaiting requested review from adamTrz adamTrz is a code owner

Assignees
No one assigned
Labels
feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@szymonrybczak @thymikee