Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change how icons are loaded and fit in dark mode.Change stroke-width to 2 to make it clearer #21

Closed
wants to merge 2 commits into from

Conversation

zxuanhong
Copy link
Contributor

@zxuanhong zxuanhong commented Apr 29, 2023

  1. Change the icon loading mode to html so that you can change the color
    using the css
.djs-context-pad > .group .bpmn-icon-color {
    fill: #1e80ff !important;
}

image

  1. Change the color's default fill color and stroke color by adding a theme configuration to fit the dark mode
colorPicker: {
    colors: CUSTOM_COLOR_PICKER_COLORS,
    theme:'dark' // light(default) or dark
 }

image

  1. Change colorIcon stroke-width to 2 to make it clearer

zxiaozhou added 2 commits April 29, 2023 18:20
1. Change the icon loading mode to html so that you can change the color
using the css
2. Change the color's default fill color and stroke color
by adding a theme configuration to fit the dark mode
Change stroke-width to 2 to make it clearer
@smbea
Copy link

smbea commented May 23, 2023

Could you split this into two PRS? One for changing the loading method (similar to bpmn-io/bpmn-js-create-append-anything#7) and a follow up with the theme related changes?

@zxuanhong
Copy link
Contributor Author

zxuanhong commented May 23, 2023 via email

@zxuanhong zxuanhong closed this by deleting the head repository May 24, 2023
@zxuanhong
Copy link
Contributor Author

zxuanhong commented May 24, 2023

@smbea I have changed it, please look at #24
I don't think it's appropriate to change the theme, I should change the default fill and stroke colors to be similar to bpmn js (e.g. bpmn js set defaultFillColor and defaultStrokeColor)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants