Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: change the icon loading mode #24

Merged
merged 1 commit into from
May 25, 2023
Merged

feat: change the icon loading mode #24

merged 1 commit into from
May 25, 2023

Conversation

zxuanhong
Copy link
Contributor

Change the icon loading mode to html so that you can change the color
using the css

.djs-context-pad > .group .bpmn-icon-color {
    fill: #1e80ff !important;
}

image

feat: change the icon loading mode
a4414d2 
change the icon loading mode to html, which facilitates changing the
icon color
@zxuanhong
Copy link
Contributor Author

@smbea
This is the latest submission. and
i don't think it's appropriate to change the theme, I should change the default fill and default stroke colors to be similar to bpmn js (e.g. bpmn js set defaultFillColor and defaultStrokeColor).It will be submitted later

@zxuanhong zxuanhong mentioned this pull request May 24, 2023
Closed
smbea
smbea approved these changes May 25, 2023
View reviewed changes
Copy link

@smbea smbea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution!

@fake-join fake-join bot merged commit 485674d into bpmn-io:master May 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smbea smbea smbea approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zxuanhong @smbea