Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support placeholders on String and Text properties #103

Merged
merged 1 commit into from
Jun 4, 2024

Conversation

barmac
Copy link
Member

@barmac barmac commented May 28, 2024

Closes #92

Requires camunda/element-templates-json-schema#144 and bpmn-io/properties-panel#363 to be released and integrated.

@bpmn-io-tasks bpmn-io-tasks bot added the in progress Currently worked on label May 28, 2024
@barmac barmac force-pushed the 92-support-placeholder-for-text-properties branch 2 times, most recently from 7f43875 to 41612f9 Compare May 29, 2024 16:29
@barmac
Copy link
Member Author

barmac commented May 29, 2024

@nikku @marstamm I won't be able to finish this PR this week as I'm off from now on.

@barmac barmac force-pushed the 92-support-placeholder-for-text-properties branch from 41612f9 to 5b53d13 Compare June 3, 2024 09:15
Closes #92

deps: update to `@bpmn-io/properties-panel@3.20.0`

deps: update to `@bpmn-io/element-templates-validator@2.1.0`
@barmac barmac force-pushed the 92-support-placeholder-for-text-properties branch from 5b53d13 to 81b819d Compare June 3, 2024 09:30
@barmac
Copy link
Member Author

barmac commented Jun 3, 2024

I added support for placeholders in Camunda 7 templates. Unfortunately, this does not include input/output parameters as they are implemented in bpmn-js-properties-panel. This can be done in a separate PR.

@barmac barmac marked this pull request as ready for review June 3, 2024 09:33
@bpmn-io-tasks bpmn-io-tasks bot added needs review Review pending and removed in progress Currently worked on labels Jun 3, 2024
@barmac barmac requested review from a team, philippfromme and marstamm and removed request for a team June 3, 2024 09:33
Copy link
Collaborator

@marstamm marstamm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great! I only found some weird behavior for text areas, but this is not related to the placeholder feature ==> #105

I love that we also implemented it for C7 templates ❤️

@barmac barmac merged commit 86a3c03 into main Jun 4, 2024
8 checks passed
@barmac barmac deleted the 92-support-placeholder-for-text-properties branch June 4, 2024 08:37
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label Jun 4, 2024
@nikku
Copy link
Member

nikku commented Jun 4, 2024

👏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Support placeholder for properties (String, Text)
3 participants