Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support placeholder in text and FEEL text entries #363

Merged
merged 2 commits into from
May 29, 2024
Merged

Conversation

barmac
Copy link
Member

@barmac barmac commented May 28, 2024

This PR implements placeholder property in the entries used in the element templates project. We can implement it in other entries (where it makes sense) if we decide to adopt placeholders everywhere.

Related to bpmn-io/bpmn-js-element-templates#92

@barmac barmac requested review from a team, philippfromme and marstamm and removed request for a team May 28, 2024 13:22
@bpmn-io-tasks bpmn-io-tasks bot added the needs review Review pending label May 28, 2024
@barmac
Copy link
Member Author

barmac commented May 28, 2024

Note that for some entries (e.g. checkbox), placeholder does not make sense. So we will never have placeholders for all entries.

Copy link
Member

@nikku nikku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good stuff 👏

@barmac barmac merged commit 726ca37 into main May 29, 2024
14 checks passed
@barmac barmac deleted the support-placeholder branch May 29, 2024 10:45
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label May 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants