Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: auto resize text areas by default #377

Merged
merged 1 commit into from
Jul 30, 2024
Merged

feat: auto resize text areas by default #377

merged 1 commit into from
Jul 30, 2024

Conversation

jarekdanielak
Copy link
Contributor

Related to bpmn-io/bpmn-js-properties-panel#713
Related to camunda/camunda-modeler#3660

Proposed Changes

Text area will auto resize by default.

Checklist

To ensure you provided everything we need to look at your PR:

  • Brief textual description of the changes present
  • Visual demo attached
  • Steps to try out present, i.e. using the @bpmn-io/sr tool
  • Related issue linked via Closes {LINK_TO_ISSUE} or Related to {LINK_TO_ISSUE}

@barmac
Copy link
Member

barmac commented Jul 30, 2024

A side effect of this is that the documentation field is one-line high, but I think that's fine:

image

@barmac
Copy link
Member

barmac commented Jul 30, 2024

MacOS hangs on npm ci, but it works locally.

@barmac barmac merged commit 3c4cc39 into main Jul 30, 2024
10 of 12 checks passed
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label Jul 30, 2024
@barmac barmac deleted the default-auto-resize branch July 30, 2024 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants