Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adaptive size of the documentation text box #3660

Closed
ingorichtsmeier opened this issue Jun 9, 2023 · 9 comments · Fixed by #4439
Closed

Adaptive size of the documentation text box #3660

ingorichtsmeier opened this issue Jun 9, 2023 · 9 comments · Fixed by #4439
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers properties panel ux
Milestone

Comments

@ingorichtsmeier
Copy link

ingorichtsmeier commented Jun 9, 2023

Problem you would like to solve

Having a huge documentation text, I can increase the size of the textbox to see all at once.

When I select another element and coming back to the one with the huge documentation, the box shrinks again to the default size.

Proposed solution

  • The textbox for Documentation should remember its size after increasing for all elements.
  • We want to persist that information across modeler sessions (i.e. in persisted layout configuration)

Alternatives considered

Show everything by default.

But this could be distracting for users that don't care about the complete documentation and are only interested if a documentation exists or not.

Additional context

The diagram converter from https://github.com/camunda-community-hub/camunda-7-to-8-migration generates all migrations into the documentation element.

Depending on the Camunda 7 element configuration and element content, it could become many characters and sentences.

@ingorichtsmeier ingorichtsmeier added the enhancement New feature or request label Jun 9, 2023
@nikku
Copy link
Member

nikku commented Jun 9, 2023

@ingorichtsmeier Could you share a screenshot of the migration text generated and attach it to the issue?

I guess what you envision is something like what we have with the FEEL editor, right?

capture cz4bqN_optimized

@nikku nikku added the needs more information Requires additional information to be actionable. label Jun 9, 2023
@ingorichtsmeier
Copy link
Author

Not exactly.

Here is a screenshot:
grafik

I could not show everything, because it contains sensitive information. But the size of the scroll bar shows how long it can become.

I think it is OK to save the new size of the textbox and apply it to all other BPMN elements. They usually have different content and I have chosen the largest.

@nikku
Copy link
Member

nikku commented Jun 11, 2023

The textbox for Documentation should remember its size after increasing for all elements.

We cannot remember across sessions, but we may be able to remember within an individual session.

@ingorichtsmeier
Copy link
Author

What about adding the size to config.json on disk?

I found this file in AppData\Roaming\camunda-modeler even touched today without using the modeler. It's still running in background.

@nikku
Copy link
Member

nikku commented Jun 12, 2023

What about adding the size to config.json on disk?

That is a away to persist it. Good idea. I updated the issue accordingly.

@nikku nikku added ux backlog Queued in backlog properties panel good first issue Good for newcomers and removed needs more information Requires additional information to be actionable. labels Jun 12, 2023
@vishalsingh2972
Copy link

@nikku can you assign this to me, want to give this a try!

@nikku
Copy link
Member

nikku commented Jun 28, 2023

Happy to take your contribution in the form of a PR. We don't usually assign external contributors.

@barmac
Copy link
Contributor

barmac commented Jun 26, 2024

We already have it in the name field of the BPMN editor.

@jarekdanielak
Copy link
Contributor

Fixed upstream by bpmn-io/properties-panel#377

barmac added a commit that referenced this issue Aug 1, 2024
@bpmn-io-tasks bpmn-io-tasks bot added needs review Review pending and removed fixed upstream Requires integration of upstream change labels Aug 1, 2024
@barmac barmac closed this as completed in ab7aebd Aug 1, 2024
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label Aug 1, 2024
@github-actions github-actions bot added this to the M79 milestone Aug 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers properties panel ux
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants