Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

Sync UX Hotfix - Codewords Alert Popup #4470

Closed
diracdeltas opened this issue Nov 4, 2021 · 3 comments · Fixed by #4471
Closed

Sync UX Hotfix - Codewords Alert Popup #4470

diracdeltas opened this issue Nov 4, 2021 · 3 comments · Fixed by #4471
Assignees
@soner-yuksel
Labels
Epic: Sync priority/P1 A very extremely bad problem. We might push a hotfix for it. release/blocking

Comments

@diracdeltas
Copy link
Member

See details at https://github.com/brave/internal/issues/824
@diracdeltas diracdeltas added priority/P1 A very extremely bad problem. We might push a hotfix for it. QA/Yes labels Nov 4, 2021
@kjozwiak kjozwiak added this to the 1.32.2 milestone Nov 4, 2021
iccub added a commit that referenced this issue Nov 4, 2021
@iccub
Fix #4470: Sync UX hotfix.
8af21a7
@iccub iccub self-assigned this Nov 4, 2021
@iccub iccub mentioned this issue Nov 4, 2021
Merged
7 tasks
iccub added a commit that referenced this issue Nov 4, 2021
@iccub
Fix #4470: Sync UX hotfix. (#4471)
aa2b865
iccub added a commit that referenced this issue Nov 4, 2021
@iccub
Fix #4470: Sync UX hotfix. (#4471)
07e1c6c
@kjozwiak
Copy link
Member

kjozwiak commented Nov 8, 2021 •
edited
Loading

Verification PASSED on the following devices/builds:

  • iPhone running iOS 15.0.2 using 1.32.2 (21.11.4.20)
  • iPad 5th Gen running iOS 14 using 1.32.2(21.11.4.20)
  • iPad 5th Gen running iOS 15 using 1.32.2(21.11.4.20)

QA verification notes can be found via https://github.com/brave/internal/issues/824#issuecomment-962128671. @LaurenWags @stephendonner thanks for running through the verifications 👍

@kjozwiak kjozwiak mentioned this issue Nov 8, 2021
Closed
@fmarier fmarier mentioned this issue Nov 22, 2021
Open
@soner-yuksel
Copy link
Contributor

Opened this ticket again, because it is removed with brave/brave-browser#19670 but this is causing incompatibility with Android right now.

So it has to be added back until brave/brave-browser#19670 is address on Android side.

@soner-yuksel soner-yuksel reopened this Aug 16, 2023
@soner-yuksel soner-yuksel modified the milestones: 1.32.2, 1.57 Aug 16, 2023
@soner-yuksel soner-yuksel changed the title Sync UX hotfix Sync UX Hotfix - Codewords Alert Popup Aug 16, 2023
@iccub iccub assigned soner-yuksel and unassigned iccub Aug 16, 2023
@soner-yuksel soner-yuksel removed this from the 1.57 milestone Aug 16, 2023
@soner-yuksel soner-yuksel mentioned this issue Aug 16, 2023
Closed
@soner-yuksel
Copy link
Contributor

Closing this because the new conditions will be addressed with #7887

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@soner-yuksel soner-yuksel

Labels
Epic: Sync priority/P1 A very extremely bad problem. We might push a hotfix for it. release/blocking
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix #4470: Sync UX hotfix. brave/brave-ios
4 participants
@diracdeltas @kjozwiak @soner-yuksel @iccub