This repository has been archived by the owner on May 10, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 442
Sync UX improvement - Conditional Device Number #7887
Milestone
Comments
This was referenced Aug 16, 2023
Brandon-T
pushed a commit
that referenced
this issue
Aug 28, 2023
* Separating the logic data for scan sync * Add pass and error cases * Improving upon joining chain and fetching devices * Processing entire device list count criteria and leave - join dance * Edge cases and errors are taken care of for error alert and such
11 tasks
iccub
pushed a commit
that referenced
this issue
Aug 29, 2023
11 tasks
Verified on Test Plan: #7918 (comment) Case: 1-4 devices
Case: 5-9 devices
|
arthuredelstein
pushed a commit
to brave/brave-core
that referenced
this issue
Feb 13, 2024
…mber (brave/brave-ios#7918) * Separating the logic data for scan sync * Add pass and error cases * Improving upon joining chain and fetching devices * Processing entire device list count criteria and leave - join dance * Edge cases and errors are taken care of for error alert and such
arthuredelstein
pushed a commit
to brave/brave-core
that referenced
this issue
Feb 13, 2024
…mber - Localization Change (brave/brave-ios#7984)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Details at brave/brave-browser#19670 and Slack discussion.
Android ticket brave/brave-browser#32286
This is a follow up upon #4470
When connecting the sync chain, we should:
I. Don't enable by default any sync types except device info, to prevent data leak.
II. Look on the number of existing devices in the chain, excluding ours:
1..4 devices - join the chain silently and enable bookmarks
5..9 devices - show alert (are you sure) with device list; if user answers no - leave chain, if yes - enable the bookmarks type
10 and more - add alert to block and prevent sync (leave chain)
Also existing confirmation dialogs must be removed. (iOS case should remain removed)
The text was updated successfully, but these errors were encountered: