Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

Sync UX improvement - Conditional Device Number #7887

Closed
soner-yuksel opened this issue Aug 16, 2023 · 1 comment · Fixed by #7918, #7984 or #7999
Closed

Sync UX improvement - Conditional Device Number #7887

soner-yuksel opened this issue Aug 16, 2023 · 1 comment · Fixed by #7918, #7984 or #7999

Comments

@soner-yuksel
Copy link
Contributor

soner-yuksel commented Aug 16, 2023

Details at brave/brave-browser#19670 and Slack discussion.

Android ticket brave/brave-browser#32286
This is a follow up upon #4470

When connecting the sync chain, we should:
I. Don't enable by default any sync types except device info, to prevent data leak.
II. Look on the number of existing devices in the chain, excluding ours:

1..4 devices - join the chain silently and enable bookmarks
5..9 devices - show alert (are you sure) with device list; if user answers no - leave chain, if yes - enable the bookmarks type
10 and more - add alert to block and prevent sync (leave chain)

Also existing confirmation dialogs must be removed. (iOS case should remain removed)

@soner-yuksel soner-yuksel added this to the 1.58 milestone Aug 16, 2023
@soner-yuksel soner-yuksel self-assigned this Aug 16, 2023
Brandon-T pushed a commit that referenced this issue Aug 28, 2023
* Separating the logic data for scan sync
* Add pass and error cases
* Improving upon joining chain and fetching devices
* Processing entire device list count criteria and leave - join dance
* Edge cases and errors are taken care of for error alert and such
@Uni-verse
Copy link
Contributor

Verified on iPhone X running iOS 16.5.1 using version 1.58 (23.9.22.13)

Test Plan: #7918 (comment)

Case: 1-4 devices
  • Ensured that device joins sync chain silently when < 4 devices connected.
  • Ensured that only Device Info type is enabled by default
Example Example
IMG_3522 IMG_3525
Case: 5-9 devices
  • Ensured that alert is shown with device list.
  • Ensured that device is not connected to chain if user selects Cancel
  • Ensured that device is connected to sync chain if user selects Confirm
  • Ensured that joining sync chain is successful using QR code as well as entering code words after confirming on the prompt.
Example Example
IMG_3519 IMG_3521
Case: 10 devices
  • Ensured Error is shown preventing user from joining chain due to maximum number of devices connected.

IMG_3520

arthuredelstein pushed a commit to brave/brave-core that referenced this issue Feb 13, 2024
…mber (brave/brave-ios#7918)

* Separating the logic data for scan sync
* Add pass and error cases
* Improving upon joining chain and fetching devices
* Processing entire device list count criteria and leave - join dance
* Edge cases and errors are taken care of for error alert and such
arthuredelstein pushed a commit to brave/brave-core that referenced this issue Feb 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.