Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

Switching Private Mode Tab Tray cause position loss in Normal Mode #7996

Closed
soner-yuksel opened this issue Aug 30, 2023 · 1 comment · Fixed by #8015
Closed

Switching Private Mode Tab Tray cause position loss in Normal Mode #7996

soner-yuksel opened this issue Aug 30, 2023 · 1 comment · Fixed by #8015

Comments

@soner-yuksel
Copy link
Contributor

Description:

When user open Tab Tray in normal mode and switched to private mode, the position in normal mode is put back up to the beginning. This causes confusion for the user especially if they had multiple tabs.

Steps to Reproduce

  1. Open Tab Tray
  2. Check which tab is highlighted in the collection view and where is the scrool
  3. Switch to private mode
  4. And back to normal mode
  5. Check position in Tab tray is lost entirely and positioned to top

Actual result:

RPReplay_Final1693414528.MP4

It is pointing top of the list

Expected result:

It should show where the selected tab position is

Reproduces how often: [Easily reproduced, Intermittent Issue]

Every time

Brave Version:

  • Can you reproduce this issue with the most recent build from TestFlight? True
  • Can you reproduce this issue with the previous version of the current build from TestFlight? True
  • Can you reproduce this issue with the current build from AppStore? True

Device details:

Any

Website problems only:

  • did you check with Brave Shields down? N/A
  • did you check in Safari/Firefox (WkWebView-based browsers)? N/A
@hffvld
Copy link
Collaborator

hffvld commented Sep 28, 2023

Verified on iPhone 14 using version(s):

Device/OS: iPhone 14 [iOS 17.0]
Brave build: 1.58 (23.9.26.21)
BraveCore: 1.58.129 (117.0.5938.88)

STEPS:
Followed the steps from #7996 (comment)

ACTUAL RESULTS:

  • Verified that the previously selected tab stays selected after returning from Private Mode to Normal Mode
  • Verified that tab position is not lost after returning from Private Mode to Normal Mode
  • Verified that switching back from Private Mode to Normal Mode always positions the selected tab in the viewing area

2023-09-27_17-27-49.mp4

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants