Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

Fix #7996: Switching Private Mode Tab Tray cause position loss in Normal Mode #8015

Merged
merged 2 commits into from
Sep 2, 2023

Conversation

soner-yuksel
Copy link
Contributor

Summary of Changes

This pull request fixes #7996

Fixing normal mode private mode persistent tab switches as well as positioning in tab tray

Submitter Checklist:

  • Unit Tests are updated to cover new or changed functionality
  • User-facing strings use NSLocalizableString()
  • New or updated UI has been tested across:
    • Light & dark mode
    • Different size classes (iPhone, landscape, iPad)
    • Different dynamic type sizes

Test Plan:

  • Open Tab Tray
  • Check which tab is highlighted in the collection view and where is the scrool
  • Switch to private mode
  • And back to normal mode
  • Check position in Tab tray is lost entirely and positioned to top
  • Check

Screenshots:

RPReplay_Final1693595151.mov

Reviewer Checklist:

  • Issues include necessary QA labels:
    • QA/(Yes|No)
    • bug / enhancement
  • Necessary security reviews have taken place.
  • Adequate unit test coverage exists to prevent regressions.
  • Adequate test plan exists for QA to validate (if applicable).
  • Issue and pull request is assigned to a milestone (should happen at merge time).

@soner-yuksel soner-yuksel self-assigned this Sep 1, 2023
@soner-yuksel soner-yuksel requested a review from a team as a code owner September 1, 2023 19:09
@iccub iccub added this to the 1.58 milestone Sep 2, 2023
@iccub iccub merged commit 320c367 into development Sep 2, 2023
8 checks passed
@iccub iccub deleted the fix/private-mode-scroll branch September 2, 2023 07:15
iccub pushed a commit that referenced this pull request Sep 4, 2023
arthuredelstein pushed a commit to brave/brave-core that referenced this pull request Feb 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Switching Private Mode Tab Tray cause position loss in Normal Mode
2 participants