Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken rust security-framework dependency #225

Merged
merged 2 commits into from
May 24, 2024
Merged

Conversation

dangeross
Copy link
Collaborator

This PR fixes a bug in the security-framework dependency that causes runtime errors on iOS:

Undefined symbols for architecture arm64:
  "_kSecMatchSubjectWholeString", referenced from:
      security_framework::item::ItemSearchOptions::search::ha6a003135e844d8e in libbreez_liquid_sdk_bindings.a[796](security_framework-270fe818f74ec369.security_framework.f033e13a96b29f56-cgu.08.rcgu.o)
ld: symbol(s) not found for architecture arm64

@erdemyerebasmaz
Copy link
Contributor

This PR fixes a bug in the security-framework dependency that causes runtime errors on iOS:

Undefined symbols for architecture arm64:
  "_kSecMatchSubjectWholeString", referenced from:
      security_framework::item::ItemSearchOptions::search::ha6a003135e844d8e in libbreez_liquid_sdk_bindings.a[796](security_framework-270fe818f74ec369.security_framework.f033e13a96b29f56-cgu.08.rcgu.o)
ld: symbol(s) not found for architecture arm64

Thanks @dangeross !!

Where do we lock the security-framework version? I can only see Cargo.lock changes. Wouldn't it be updated on next "cargo update" call?

@ok300
Copy link
Contributor

ok300 commented May 24, 2024

I added a commit that pins security-framework and security-framework-sys in Cargo.toml, which means they won't be bumped even on cargo update.

Are there any others that have to be pinned other than these two?

@dangeross
Copy link
Collaborator Author

Are there any others that have to be pinned other than these two?

I think it's enough

@dangeross dangeross merged commit 5143aeb into main May 24, 2024
0 of 5 checks passed
@dangeross dangeross deleted the savage-fix-ios-build branch May 24, 2024 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants