fix: Exclude macOS-only Keychain symbol for iOS compatibility #204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Inclusion of the `kSecMatchSubjectWholeString` symbol when compiling for iOS, which is not supported according to Apple's documentation, is prevented. Conditional compilation directives are added to ensure that builds targeted for iOS do not use macOS exclusive Keychain functionalities. This adjustment resolves a compilation failure encountered following an update of the 'rust-security-framework' dependency, thereby enhancing the cross-platform compatibility of the SDK.
|
This PR resolves #203 |
CyonAlexRDX
pushed a commit
to radixdlt/sargon
that referenced
this pull request
May 16, 2024
dani-garcia
added a commit
to bitwarden/sdk
that referenced
this pull request
Jun 3, 2024
## 📔 Objective I'm having compile errors running the iOS build, caused by the latest version of the `security-framework` crate including some MacOS symbols into the iOS binary. The bug is [fixed upstream](kornelski/rust-security-framework#204) but there haven't been any releases since then, so for now the best course of action is to pin the crate to the previous working version. ## ⏰ Reminders before review - Contributor guidelines followed - All formatters and local linters executed and passed - Written new unit and / or integration tests where applicable - Protected functional changes with optionality (feature flags) - Used internationalization (i18n) for all UI strings - CI builds passed - Communicated to DevOps any deployment requirements - Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team ## 🦮 Reviewer guidelines <!-- Suggested interactions but feel free to use (or not) as you desire! --> - 👍 (`:+1:`) or similar for great changes - 📝 (`:memo:`) or ℹ️ (`:information_source:`) for notes or general info - ❓ (`:question:`) for questions - 🤔 (`:thinking:`) or 💭 (`:thought_balloon:`) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion - 🎨 (`:art:`) for suggestions / improvements - ❌ (`:x:`) or⚠️ (`:warning:`) for more significant problems or concerns needing attention - 🌱 (`:seedling:`) or ♻️ (`:recycle:`) for future improvements or indications of technical debt - ⛏ (`:pick:`) for minor or nitpick changes
|
when is this going to be released? |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inclusion of the
kSecMatchSubjectWholeStringsymbol when compiling for iOS, which is not supported according to Apple's documentation, is prevented. Conditional compilation directives are added to ensure that builds targeted for iOS do not use macOS exclusive Keychain functionalities.This adjustment resolves a compilation failure encountered following an update of the 'rust-security-framework' dependency, thereby enhancing the cross-platform compatibility of the SDK.