Proof that SargonOS does not introduce non-trivial breaking changes #1190
Conversation
…t however you like. IT IS NOT IMPORTANT data passed to creation of DeviceFactorSources.
| @@ -181,6 +181,7 @@ extension DebugInspectFactorSourceView { | |||
| DeviceFactorSouceView(deviceFactorSource: deviceFactorSource) | |||
| case let .ledger(ledgerFactorSource): | |||
| LedgerFactorSourceView(ledgerFactorSource: ledgerFactorSource) | |||
| default: fatalError("DISCREPANCY: Found non .device | .ledger factor source. A real world user cannot possible have this.") | |||
There was a problem hiding this comment.
This is safe for our users, it is not possible for our users to create any other factor source than DeviceFactorSource or LedgerFactorSource.
| @@ -89,6 +89,8 @@ public struct DerivePublicKeys: Sendable, FeatureReducer { | |||
| .device | |||
| case let .ledger(ledger): | |||
| .ledger(ledger) | |||
| default: | |||
| fatalError("DISCREPANCY: Found non .device | .ledger factor source. A real world user cannot possible have this.") | |||
There was a problem hiding this comment.
This is safe for our users, it is not possible for our users to create any other factor source than DeviceFactorSource or LedgerFactorSource.
| @@ -210,6 +212,7 @@ public struct DerivePublicKeys: Sendable, FeatureReducer { | |||
| ) | |||
| case let .ledger(ledgerFactorSource): | |||
| return deriveWith(ledgerFactorSource: ledgerFactorSource, state) | |||
| default: fatalError("DISCREPANCY: Found non .device | .ledger factor source. A real world user cannot possible have this.") | |||
There was a problem hiding this comment.
This is safe for our users, it is not possible for our users to create any other factor source than DeviceFactorSource or LedgerFactorSource.
| @@ -195,8 +195,7 @@ public struct Signing: Sendable, FeatureReducer { | |||
| signingFactors: nextFactors, | |||
| signingPurposeWithPayload: signingPurposeWithPayload | |||
| ) | |||
| case .offDeviceMnemonic, .securityQuestions, .trustedContact: | |||
| fatalError("Implement me") | |||
| default: fatalError("DISCREPANCY: Found non .device | .ledger factor source. A real world user cannot possible have this.") | |||
There was a problem hiding this comment.
This is safe for our users, it is not possible for our users to create any other factor source than DeviceFactorSource or LedgerFactorSource.
| // MUST NOT be called twice (panics...) | ||
| // MUST NOT be enabled in PROD (not ensured that secrets are omitted) | ||
| // This is VERY VERY verbose, so mosly useful for debugging. | ||
| enableLoggingFromRust() |
There was a problem hiding this comment.
We should use SargonOS loggin systems instead. So I removed that freestanding enable log function in Sargon.
Important
Cannot be merged until SargonOS PR radixdlt/sargon#176 has been merged.
Merge SargonOS, then update this, which uses LOCAL Sargon, and use new version.
It fixes the breaking changes introduce by it - non are hard, easy changes.
The biggest change is really that DeviceFactorSource creation method takes a
DeviceInfoto populate theDeviceFactorSourceHint. This is not important, and I dont thin we even display this to the user.This PR could/should be clean up! And can be cleaned up in several ways, but I have no time to do it.
One idea is to create a new temporary method on
SecureStorageClientloadDeviceInfoOrFallbackor similar, which is a non-throwing function which returns a non-optionalDeviceInfowith description "iPhone"/.Once again, this info is not at all crucial. Feel free to use whatever workaround suits you!
Or a bit more elegant, is to change declare an initialiser in Swift Sargon which takes an optional
DeviceInfo...I gave it a quick spin and it seems to work fine! (I got some iCloud error, but it is most likely completely unrelated)
RPReplay_Final1719589001.MP4