Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SargonOS + MFA Batch 1 #176

Merged
merged 9 commits into from
Jul 29, 2024
Merged

SargonOS + MFA Batch 1 #176

merged 9 commits into from
Jul 29, 2024

Conversation

CyonAlexRDX
Copy link
Contributor

@CyonAlexRDX CyonAlexRDX commented Jun 28, 2024

…(working example app)! (#131)

Introducing SargonOS
MFA Batch 1: SecurityStructureOfFactorSources and MatrixOfFactorSoures and also on FactorSourceID and FactorInstance level. Also add some new FactorSourceKinds at least a POC version of them or stubbed out ones.
Copy link

codecov bot commented Jun 28, 2024

Codecov Report

Attention: Patch coverage is 98.15100% with 12 lines in your changes missing coverage. Please review.

Project coverage is 97.4%. Comparing base (598a8a4) to head (b0302ce).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##            main    #176     +/-   ##
=======================================
- Coverage   98.3%   97.4%   -0.9%     
=======================================
  Files        781     906    +125     
  Lines      11961   14489   +2528     
  Branches      39      38      -1     
=======================================
+ Hits       11758   14119   +2361     
- Misses       199     364    +165     
- Partials       4       6      +2     
Flag Coverage Δ
kotlin 96.6% <84.2%> (-0.7%) ⬇️
rust 97.0% <97.5%> (-1.1%) ⬇️
swift 99.5% <98.9%> (-0.1%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...s/EntropyProvider/EntropyProvider+RandomData.swift 100.0% <100.0%> (ø)
...ple/Sources/Sargon/Drivers/EventBus/EventBus.swift 100.0% <100.0%> (ø)
...rivers/EventBus/EventNotification+Swiftified.swift 100.0% <100.0%> (ø)
...argon/Drivers/Logging/LoggingDriver+SwiftLog.swift 100.0% <100.0%> (ø)
...ivers/Networking/NetworkingDriver+URLSession.swift 100.0% <100.0%> (ø)
...iver+InsecureTestOnlyEphemeral_SecureStorage.swift 100.0% <100.0%> (ø)
...urces/Sargon/Drivers/TestDrivers/TestDrivers.swift 100.0% <100.0%> (ø)
...safeStorage/UnsafeStorageDriver+UserDefaults.swift 100.0% <100.0%> (ø)
...Methods/Crypto/Keys/PrivateHD+Wrap+Functions.swift 100.0% <100.0%> (ø)
...ns/Methods/Prelude/Decimal192+Wrap+Functions.swift 97.9% <100.0%> (ø)
... and 84 more

... and 152 files with indirect coverage changes

Revert Profile JSON format changes in DeviceInfo
@CyonAlexRDX CyonAlexRDX marked this pull request as ready for review June 28, 2024 19:53
@CyonAlexRDX
Copy link
Contributor Author

CyonAlexRDX commented Jun 28, 2024

@GhenadieVP This is now merge ready, the iOS repo contains the small needed changes in hosts: radixdlt/babylon-wallet-ios#1190

Now signing off for the summer!

@micbakos-rdx
Copy link
Contributor

micbakos-rdx commented Jul 10, 2024

@GhenadieVP, @sergiupuhalschi-rdx @matiasbzurovski please review these two merge commits 10d2e16 & 39c5496 and let me know if I didn't include something important.

micbakos-rdx and others added 2 commits July 25, 2024 14:46
* Implement HostInfo struct

* Store host id in secure storage

* Fix doc

* Separate id and date from host info

* Implement HostOS that will encapsulate the different values and constants of each host os

* Expose uniffi method for creating device info from host info
@GhenadieVP GhenadieVP merged commit d5ebac0 into main Jul 29, 2024
9 of 10 checks passed
@GhenadieVP GhenadieVP deleted the sargon_os branch July 29, 2024 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants