Add SwiftFormat config and pre-commit #126
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #126 +/- ##
=====================================
Coverage 98.8% 98.8%
=====================================
Files 740 740
Lines 11655 11655
Branches 23 23
=====================================
Hits 11521 11521
Misses 134 134
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
@matiasbzurovski @GhenadieVP lets close this for now and re-introduce it once we have merge #176 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog
Adds the configuration for Swift formatting and the pre-commit hook.
Notes
Format changes will be done in a separate PR, leaving this one with only the configuration changes.
Rationale
The project already had an almost empty
.swift-formatfile, that would have allowed us to use Apple's swift-format, instead of the SwiftFormat developed by nicklockwood.Even though I mostly prefer going with native tools, the Apple one doesn't allow as many rules as the selected one. Also, given we are already using it for the iOS Wallet project, it makes sense to use the same tool to easily replicate the same coding standards and styles in both projects.