App compatibility with sargon os branch #1098
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
micbakos-rdx
requested review from
jakub-rdx,
giannis-rdx and
sergiupuhalschi-rdx
micbakos-rdx
commented
Jul 25, 2024
gradle/libs.versions.toml
Outdated
| @@ -20,7 +20,7 @@ hiltNavigation = "1.2.0" | |||
| biometricKtx = "1.2.0-alpha05" | |||
| coilCompose = "2.6.0" | |||
| kotlinxSerialization = "1.6.2" | |||
| sargon = "1.0.31-598a8a45" | |||
| sargon = "1.1.0-host_info-777f0b3d" | |||
There was a problem hiding this comment.
This will be replaced to the actual build from main branch when sargon has sargon_os merged.
jakub-rdx
reviewed
Jul 29, 2024
|
|
||
| companion object { | ||
| fun generate() = HostIdEntry( | ||
| id = Uuid.randomUUID(), |
There was a problem hiding this comment.
in core we have something called UUIDGenerator. If we use Uuid class from sargon, shouldn't we consistently use one uuid "provider" everywhere?
sergiupuhalschi-rdx
approved these changes
Jul 29, 2024
jakub-rdx
approved these changes
Jul 29, 2024
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR aims to achieve compatibility with sargon os branch.
Warning
It is not booting sargon os yet, but makes our app compatible with some structural changes on radixdlt/sargon#176
Changes
whens are handled appropriately. Code that usually produces a side effect, does nothing for new factor sources, and code that needs to return a value, returns a Result.Failure with an appropriate exception. Keep in mind that such errors will not be thrown since these factor sources are not operational.DeviceInfowas replaced withHostIdandHostInfo. For more information related to those 2 objects in sargon take a look at this pr Implement HostInfo struct sargon#189. In general the id and timestamp it was generated are the only information needed to be preserved (used heavily in the backup feature). The rest can be retrieved on the fly usingcontextorBuildinformation. Check this testprofile/src/test/java/rdx/works/profile/data/HostInfoRepositoryTest.ktthat tests the compatibility between the previous and the new object that preserves the id of the device.How to test
This branch will be merged when radixdlt/sargon#176 is merged to main