-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
App compatibility with sargon os branch #1098
Conversation
gradle/libs.versions.toml
Outdated
@@ -20,7 +20,7 @@ hiltNavigation = "1.2.0" | |||
biometricKtx = "1.2.0-alpha05" | |||
coilCompose = "2.6.0" | |||
kotlinxSerialization = "1.6.2" | |||
sargon = "1.0.31-598a8a45" | |||
sargon = "1.1.0-host_info-777f0b3d" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will be replaced to the actual build from main branch when sargon has sargon_os
merged.
|
||
companion object { | ||
fun generate() = HostIdEntry( | ||
id = Uuid.randomUUID(), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
in core
we have something called UUIDGenerator
. If we use Uuid
class from sargon, shouldn't we consistently use one uuid "provider" everywhere?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested on top of a version with backup enabled and it works as expected.
|
Description
This PR aims to achieve compatibility with sargon os branch.
Warning
It is not booting sargon os yet, but makes our app compatible with some structural changes on radixdlt/sargon#176
Changes
when
s are handled appropriately. Code that usually produces a side effect, does nothing for new factor sources, and code that needs to return a value, returns a Result.Failure with an appropriate exception. Keep in mind that such errors will not be thrown since these factor sources are not operational.DeviceInfo
was replaced withHostId
andHostInfo
. For more information related to those 2 objects in sargon take a look at this pr Implement HostInfo struct sargon#189. In general the id and timestamp it was generated are the only information needed to be preserved (used heavily in the backup feature). The rest can be retrieved on the fly usingcontext
orBuild
information. Check this testprofile/src/test/java/rdx/works/profile/data/HostInfoRepositoryTest.kt
that tests the compatibility between the previous and the new object that preserves the id of the device.How to test
This branch will be merged when radixdlt/sargon#176 is merged to main