Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: BeforeScopeInterface (2.x) #261

Conversation

jamisonbryant
Copy link
Contributor

@jamisonbryant jamisonbryant commented Nov 8, 2023

See #260 for a detailed description.

This PR contains the same changes for the 2.x branch (CakePHP v4) branch.

Checklist

  • Tests written and passing
  • Code follows coding standards
  • Documentation updated if necessary
  • Spelling/grammar check done

dependabot bot and others added 4 commits September 4, 2023 21:09
Bumps [actions/checkout](https://github.com/actions/checkout) from 3 to 4.
- [Release notes](https://github.com/actions/checkout/releases)
- [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md)
- [Commits](actions/checkout@v3...v4)

---
updated-dependencies:
- dependency-name: actions/checkout
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
…/actions/checkout-4

Bump actions/checkout from 3 to 4
…cy-scopes-reference

Set missing reference for applying-policy-scopes
@jamisonbryant
Copy link
Contributor Author

The two stan failures are for src/Identity.php which is not a file I touched. It looks like Psalm wants me to expand the return types, but I'm not sure if I should do that since it's unrelated to the changes made in this PR.

Any suggestions what I should do? All the other checks pass.

@ADmad ADmad changed the base branch from 2.x to 2.next November 8, 2023 19:19
@ADmad
Copy link
Member

ADmad commented Nov 8, 2023

Please rebase your changes on the 2.next branch.

New features need to target The x.next branches as they require new minor releases.

@jamisonbryant jamisonbryant force-pushed the feature/before-scope-interface-2.x branch from d6e5ff1 to 51f7050 Compare November 8, 2023 19:43
@jamisonbryant
Copy link
Contributor Author

@ADmad I think I did it, but I'm not so familiar with doing rebases on a fork. Does it look right now?

@jamisonbryant
Copy link
Contributor Author

Closing, will attempt to recreate and hope that cleans up the commits.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants