Feature: BeforeScopeInterface (2.next) #264
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
OK, this time I actually did it right and this branch is now based on It does still have the stan failure for |
|
The stan issue will be fixed by #263 so we can ignore that. |
LordSimal
approved these changes
Nov 10, 2023
|
@jamisonbryant all you have to do now is click on the triangle next to the Then the CI in Github should be green. |
|
I forgot that rebasing a fork has some additional steps. I'd say lets just merge this 😁 |
jamisonbryant
force-pushed
the
feature/before-scope-interface-2.x
branch
from
de525c1
to
c1bf244
Compare
ADmad
reviewed
Nov 10, 2023
Co-authored-by: ADmad <ADmad@users.noreply.github.com>
ADmad
approved these changes
Nov 10, 2023
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Redo of #261 but with changes rebased on 2.next