Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

It is possible to undo redo on the form output panel #4216

Closed
barmac opened this issue Mar 27, 2024 · 0 comments · Fixed by #4219
Closed

It is possible to undo redo on the form output panel #4216

barmac opened this issue Mar 27, 2024 · 0 comments · Fixed by #4219
Assignees
@barmac
Labels
bug Something isn't working

Comments

@barmac
Copy link
Contributor

barmac commented Mar 27, 2024 •
edited
Loading

Copied from bpmn-io/form-js#1107

Describe the Bug

image

The form output panel is a non editable state representation of the form output, but it is still possible to ctrl-z/ctrl-y to undo/redo changes to it.

Steps to Reproduce

  1. run the playground
  2. edit a field
  3. press ctrl-z while in focus of the form output panel
  4. the edit to the field is reverted

Expected Behavior

  1. nothing should happen, this pane should be read-only

Context

Introduced in v5.22.0-rc.0
@barmac barmac added the bug Something isn't working label Mar 27, 2024
@barmac barmac mentioned this issue Mar 27, 2024
Closed
37 tasks
barmac added a commit that referenced this issue Mar 27, 2024
@barmac
deps: update to @bpmn-io/form-js@1.8.2
5d8d20e 
Closes #4216
Closes #4217
Closes #4218
@barmac barmac mentioned this issue Mar 27, 2024
Merged
@bpmn-io-tasks bpmn-io-tasks bot added the needs review Review pending label Mar 27, 2024
nikku pushed a commit that referenced this issue Mar 27, 2024
@barmac @nikku
deps: update to @bpmn-io/form-js@1.8.2
5814082 
Closes #4216
Closes #4217
Closes #4218
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label Mar 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@barmac barmac

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

deps: update to @bpmn-io/form-js@1.8.2 camunda/camunda-modeler
1 participant
@barmac