Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Forms editor crashes and requires restart if illegal group#path is used #4217

Closed
barmac opened this issue Mar 27, 2024 · 1 comment · Fixed by #4219
Closed

Forms editor crashes and requires restart if illegal group#path is used #4217

barmac opened this issue Mar 27, 2024 · 1 comment · Fixed by #4219
Assignees
@barmac
Labels
bug Something isn't working spring cleaning Could be cleaned up one day

Comments

@barmac
Copy link
Contributor

barmac commented Mar 27, 2024

Describe the bug

Given I set the group path to __proto__ and place an input in a group, the forms editor crashes and I have to restart the application to make it work again.

Steps to reproduce

Screen.Recording.2024-03-27.at.11.30.18.mov

Expected behavior

Value should be linted as illegal and not saved.

Environment

Both v5.22.0-rc.0 and v5.21.0 on MacOS.

Additional context

No response
@barmac barmac added bug Something isn't working backlog Queued in backlog spring cleaning Could be cleaned up one day labels Mar 27, 2024
@barmac
Copy link
Contributor Author

barmac commented Mar 27, 2024

I am placing this in the backlog as it's an edge case, and not a regression. However, I'd give it slightly higher priority than normal bugs since it's a crashing issue.

This was referenced Mar 27, 2024
Closed
Closed
@Skaiir Skaiir mentioned this issue Mar 27, 2024
Closed
barmac added a commit that referenced this issue Mar 27, 2024
@barmac
deps: update to @bpmn-io/form-js@1.8.2
5d8d20e 
Closes #4216
Closes #4217
Closes #4218
@barmac barmac mentioned this issue Mar 27, 2024
Merged
@bpmn-io-tasks bpmn-io-tasks bot added needs review Review pending and removed backlog Queued in backlog labels Mar 27, 2024
nikku pushed a commit that referenced this issue Mar 27, 2024
@barmac @nikku
deps: update to @bpmn-io/form-js@1.8.2
5814082 
Closes #4216
Closes #4217
Closes #4218
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label Mar 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@barmac barmac

Labels
bug Something isn't working spring cleaning Could be cleaned up one day
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

deps: update to @bpmn-io/form-js@1.8.2 camunda/camunda-modeler
1 participant
@barmac