Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add file extensions to lint-js script and fix the existing linting errors #4777

Open
wants to merge 23 commits into
base: main
Choose a base branch
from

Conversation

chillkang
Copy link
Contributor

@chillkang chillkang commented Jul 25, 2024

Done

How to QA

  • lint-js check should be failing since there are other linting issues left (828 errors).
  • The changes I added are in the first two files, .eslintrc.js and package.json.
  • The rest of the changes are the fixed linting errors.

Testing

  • This PR has tests
  • No testing required (explain why): Changes to ESLint configurations

Issue / Card

Fixes #https://warthogs.atlassian.net/browse/WD-13579

@webteam-app
Copy link

@chillkang chillkang marked this pull request as ready for review July 25, 2024 20:35
@chillkang chillkang force-pushed the WD-13579-fix-exisiting-js-linting-issues branch 4 times, most recently from 99ff533 to 4152877 Compare August 1, 2024 15:50
@chillkang chillkang force-pushed the WD-13579-fix-exisiting-js-linting-issues branch from 4152877 to adffda3 Compare August 6, 2024 20:55
@chillkang chillkang force-pushed the WD-13579-fix-exisiting-js-linting-issues branch 2 times, most recently from 99fe379 to 8d3bb1b Compare August 9, 2024 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants