Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix linting errors in /static/js/libs and formatting errors #4790

Merged

Conversation

chillkang
Copy link
Contributor

@chillkang chillkang commented Aug 1, 2024

Done

How to QA

  • lint-js should be failing as there are other linting errors left to be fixed
  • starting from this line, check those files below:
    static/js/libs/__tests__/iframeSize.test.ts
    static/js/libs/debounce.ts
    static/js/libs/__tests__/throttle.test.ts
    static/js/libs/__tests__/debounce.test.ts

Testing

  • This PR has tests
  • No testing required (explain why): fixing linting errors

Issue / Card

Fixes #https://warthogs.atlassian.net/browse/WD-13579

@webteam-app
Copy link

@chillkang chillkang changed the title chore: fix linting errors in /static/js/libs and formatting errros chore: fix linting errors in /static/js/libs and formatting errors Aug 1, 2024
@chillkang chillkang marked this pull request as ready for review August 1, 2024 15:53
@chillkang chillkang force-pushed the WD-13827-fix-linting-errors-in-static-js-libs branch from f02d0dc to 20158b2 Compare August 1, 2024 15:58
Copy link
Contributor

@steverydz steverydz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@chillkang chillkang force-pushed the WD-13827-fix-linting-errors-in-static-js-libs branch from e1fd6b9 to fa93dfe Compare August 6, 2024 21:02
@chillkang chillkang force-pushed the WD-13827-fix-linting-errors-in-static-js-libs branch from fa93dfe to ec7cf3b Compare August 8, 2024 16:37
Copy link

codecov bot commented Aug 8, 2024

Codecov Report

Attention: Patch coverage is 67.53247% with 25 lines in your changes missing coverage. Please review.

Project coverage is 62.89%. Comparing base (b8b6b55) to head (7d51520).
Report is 139 commits behind head on main.

Files Patch % Lines
static/js/publisher/form.ts 46.15% 7 Missing ⚠️
static/js/publisher/tour/helpers.ts 0.00% 4 Missing ⚠️
static/js/publisher/release/helpers.ts 25.00% 3 Missing ⚠️
static/js/brand-store/selectors/index.ts 80.00% 2 Missing ⚠️
static/js/public/first-snap-flow.ts 0.00% 2 Missing ⚠️
...listing/components/MetricsInputs/MetricsInputs.tsx 0.00% 2 Missing ⚠️
static/js/base/ga.ts 0.00% 1 Missing ⚠️
.../js/brand-store/components/Model/PoliciesTable.tsx 0.00% 1 Missing ⚠️
...listing/components/LicenseInputs/LicenseSearch.tsx 50.00% 1 Missing ⚠️
static/js/publisher/listing/utils/getFormData.ts 0.00% 1 Missing ⚠️
... and 1 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4790      +/-   ##
==========================================
- Coverage   66.80%   62.89%   -3.92%     
==========================================
  Files         113      160      +47     
  Lines        3714     4166     +452     
  Branches      965      640     -325     
==========================================
+ Hits         2481     2620     +139     
- Misses       1098     1359     +261     
- Partials      135      187      +52     
Files Coverage Δ
...store/components/AccountDetails/AccountDetails.tsx 25.49% <ø> (ø)
...d-store/components/AppPagination/AppPagination.tsx 69.23% <ø> (-2.20%) ⬇️
static/js/brand-store/components/Model/Model.tsx 42.55% <ø> (-6.60%) ⬇️
...s/brand-store/components/Model/ModelBreadcrumb.tsx 100.00% <ø> (ø)
...tatic/js/brand-store/components/Model/Policies.tsx 53.84% <ø> (-5.09%) ⬇️
...s/brand-store/components/Navigation/Navigation.tsx 52.00% <ø> (+12.93%) ⬆️
...ic/js/brand-store/components/Settings/Settings.tsx 57.53% <100.00%> (-3.30%) ⬇️
static/js/brand-store/hooks/index.ts 38.77% <ø> (+0.13%) ⬆️
static/js/brand-store/slices/membersSlice.ts 34.61% <ø> (ø)
static/js/brand-store/slices/snapsSlice.ts 11.53% <ø> (ø)
... and 47 more

... and 70 files with indirect coverage changes

@Lukewh Lukewh merged commit b44269c into canonical:main Aug 9, 2024
6 of 7 checks passed
@chillkang chillkang deleted the WD-13827-fix-linting-errors-in-static-js-libs branch August 9, 2024 10:41
@chillkang chillkang restored the WD-13827-fix-linting-errors-in-static-js-libs branch August 9, 2024 11:16
@chillkang chillkang deleted the WD-13827-fix-linting-errors-in-static-js-libs branch August 9, 2024 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants