-
Notifications
You must be signed in to change notification settings - Fork 190
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
C3-713: Redesign public representation for certified machines #14135
base: main
Are you sure you want to change the base?
C3-713: Redesign public representation for certified machines #14135
Conversation
andrejvelichkovski is not a collaborator of the repo |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #14135 +/- ##
=======================================
Coverage 69.63% 69.63%
=======================================
Files 120 120
Lines 3418 3418
Branches 1174 1174
=======================================
Hits 2380 2380
Misses 1013 1013
Partials 25 25 |
The |
The demo instance link: https://ubuntu-com-14135.demos.haus/ |
Converting this PR to draft as we are still awaiting on feedback from different partners. |
Glad to see it in such good shape. Just very minor comments, all for the machine pages:
+1ing this already as to not block. |
Thanks for the review @juanruitina
Sorry, I missed this, changed it now
This is a bit more complicated issue. To somewhat resolve it, I added a
Great suggestion, I now added an if clause to check this
Done.
Done. |
Done
The implementation is based on this design:
Demo examples
QA
./run serve
ordotrun
Issue / Card
Fixes C3-713
Screenshots
Machine page
Platform page
Help
QA steps - Commit guidelines