Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

C3-713: Redesign public representation for certified machines #14135

Open
wants to merge 23 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
23 commits
Select commit Hold shift + click to select a range
4b8c379
Initial implementation for Platform Page
andrejvelichkovski Aug 1, 2024
3a712c0
Merge branch 'main' into c3-713-implement-platform-view
andrejvelichkovski Aug 1, 2024
a361b3e
Merge branch 'canonical:main' into c3-713-implement-platform-view
nadzyah Aug 7, 2024
ef72ac4
Merge branch 'canonical:main' into c3-713-implement-platform-view
nadzyah Aug 8, 2024
8fb1a94
Fix bullet points in list items
nadzyah Aug 12, 2024
e98b9f8
Update certified/<canonical_id> page to match the design
nadzyah Aug 13, 2024
910fb1f
Fix style issues
nadzyah Aug 14, 2024
a07f902
Don't change certification API URL
nadzyah Aug 14, 2024
b5c35f2
Enhance the HTML
nadzyah Aug 14, 2024
d03bf2f
Merge branch 'canonical:main' into c3-713-implement-platform-view
nadzyah Aug 14, 2024
6a7429e
Implement additional changes to match design
andrejvelichkovski Aug 20, 2024
483cdcf
Merge branch 'main' into c3-713-implement-platform-view
andrejvelichkovski Aug 20, 2024
aef3c90
Add tests and clean code
andrejvelichkovski Aug 20, 2024
b25598f
Fix lint issue
andrejvelichkovski Aug 20, 2024
c0f1b50
Implement feedback suggestions
andrejvelichkovski Sep 3, 2024
8317469
Merge branch 'main' into c3-713-implement-platform-view
andrejvelichkovski Sep 3, 2024
7560e8c
Add updated cassettes
andrejvelichkovski Sep 3, 2024
923d107
Fix djlint errors
andrejvelichkovski Sep 3, 2024
39583fd
Fix issue with sorted release names
andrejvelichkovski Sep 4, 2024
cd94b0d
Fix UX suggestions
andrejvelichkovski Sep 4, 2024
4df11b1
Merge branch 'main' into c3-713-implement-platform-view
andrejvelichkovski Sep 4, 2024
8f30cc4
Add horizontal line
andrejvelichkovski Sep 4, 2024
485abe4
Fix margin issue
andrejvelichkovski Sep 4, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
47 changes: 3 additions & 44 deletions templates/certified/hardware-details.html
Original file line number Diff line number Diff line change
Expand Up @@ -15,50 +15,9 @@
<h1 class="p-heading--2">Hardware details</h1>
</div>
<div class="col-5 u-align--center u-vertically-center u-hide--medium u-hide--small">
{% if release_details.category == "Desktop" or release_details.category == "Laptop" %}
{{ image (
url="https://assets.ubuntu.com/v1/4b732966-Laptop.svg",
alt="",
width="132",
height="77",
hi_def=True,
loading="auto"
) | safe
}}
{% endif %}
{% if release_details.category == "Server" %}
{{ image (
url="https://assets.ubuntu.com/v1/fdf83d49-Server.svg",
alt="Server",
width="80",
height="96",
hi_def=True,
loading="auto"
) | safe
}}
{% endif %}
{% if release_details.category == "Ubuntu Core" %}
{{ image (
url="https://assets.ubuntu.com/v1/f9f8ace9-gateway.svg",
alt="Gateway",
width="96",
height="100",
hi_def=True,
loading="auto"
) | safe
}}
{% endif %}
{% if release_details.category == "Server SoC" %}
{{ image (
url="https://assets.ubuntu.com/v1/4e0399a1-chip.svg",
alt="Chip",
width="84",
height="100",
hi_def=True,
loading="auto"
) | safe
}}
{% endif %}
{% with category=release_details.category %}
{% include "certified/shared/category-image.html" %}
{% endwith %}
</div>
</div>
<div class="row">
Expand Down
Loading
Loading