Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(header-action): allow vertical scroll when expanded #1992

Merged
merged 1 commit into from
Aug 13, 2024

Conversation

metonym
Copy link
Collaborator

@metonym metonym commented Aug 13, 2024

This PR hotfixes a usability issue: if the HeaderAction has vertical overflow, the overflow: hidden rule is not overridden.

This should ideally be fixed upstream:

In the meantime, however, the fix for Carbon Svelte ensures that the content is vertically scrollable (if necessary) to avoid requiring user intervention. This change can be reverted if and when this style is fixed in the upstream carbon-components library.

Otherwise, the consumer would need the following CSS:

:global(.bx--header-panel--expanded) {
  overflow-y: auto;
}

Screenshot 2024-08-13 at 9 27 13 AM

@metonym metonym merged commit 61eceb0 into master Aug 13, 2024
3 checks passed
@metonym metonym deleted the fix-header-nav-scroll branch August 13, 2024 16:57
@metonym
Copy link
Collaborator Author

metonym commented Aug 14, 2024

Fixed in v0.85.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant