fix(header-panel): allow vertical overflow when expanded #17160
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for v11-carbon-react ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
tay1orjones
approved these changes
Aug 16, 2024
|
backport to v10 up at #17195 |
Merged
via the queue into
carbon-design-system:main
with commit Aug 16, 2024
1a40999
22 checks passed
Excellent, thank you 🙏 |
Gururajj77
pushed a commit
that referenced
this pull request
Aug 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #17159
When
HeaderPanelis expanded, the content is not vertically scrollable if there is overflow. See the original bug report for repro steps.The root cause is that the
--header-panelselector hasoverflow: hiddenfor the transition. However, the expanded state should allow vertical scrolling as needed.The proposed fix is to set
overflow-y: autoon the expanded state to only afford a scrollbar as needed.Note that this fix should ideally be backported to v10.
Before
After
Changelog
Changed
Testing / Reviewing