-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(ExpandableSearch): compose prop handlers with internal (#12135) #12143
fix(ExpandableSearch): compose prop handlers with internal (#12135) #12143
Conversation
…sign-system#12135) * fix(ExpandableSearch): compose prop handlers with internal
✅ Deploy Preview for carbon-components-react ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Hey @gi, thanks for the contribution and adding all the tests! I'm running into an issue where it seems like the |
@tw15egan Thanks for catching that. The |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Working great, LGTM 👍 ✅
Thanks for contributing 🎉
Closes #12135
The
ExpandableSearch
component passes a few callbacks from the underlyingSearch
component in order to control its own state.onBlur
onChange
onExpand
onFocus
These are not composed with any props on the
ExpandableSearch
component, meaning that any of those props specified will have no effect.This fixes the issue.
Changelog
Changed
ExpandableSearch
: compose event callbacks with internal handlersTesting / Reviewing