Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ExpandableSearch): compose prop handlers with internal (#12135) #12143

Merged
Show file tree
Hide file tree
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -0,0 +1,206 @@
/**
* Copyright IBM Corp. 2016, 2018
*
* This source code is licensed under the Apache-2.0 license found in the
* LICENSE file in the root directory of this source tree.
*/

import { mount } from 'enzyme';
import React from 'react';
import Search from './ExpandableSearch';

const prefix = 'cds';

describe('ExpandableSearch', () => {
let wrapper;

const container = () => wrapper.find(`.${prefix}--search`);
const button = () => wrapper.find('button');
const input = () => wrapper.find('input');
const label = () => wrapper.find('label');

const render = (props) => {
if (wrapper) {
return wrapper.setProps(props);
}

wrapper = mount(<Search labelText="testlabel" {...props} />);

return wrapper;
};

describe('container', () => {
beforeEach(() => {
render();
});

it('has the class `${prefix}--search--expandable`', () => {
const value = container().hasClass(`${prefix}--search--expandable`);
expect(value).toEqual(true);
});

describe('expanded', () => {
const value = () => container().hasClass(`${prefix}--search--expanded`);

describe('when input has no content', () => {
beforeEach(() => {
input().simulate('change', { target: { value: '' } });
});

it('is false', () => {
expect(value()).toEqual(false);
});
});

describe.skip('when input has content', () => {
beforeEach(() => {
input().simulate('change', { target: { value: 'text' } });
});

it('is true', () => {
expect(value()).toEqual(true);
});

describe('when content is cleared', () => {
beforeEach(() => {
button().simulate('click');
});

it('is false', () => {
expect(value()).toEqual(false);
});
});
});
});
});

describe('label', () => {
beforeEach(() => {
render();
});

it('is rendered', () => {
expect(label().text()).toEqual('testlabel');
});
});

describe('onBlur', () => {
const onBlur = jest.fn();

beforeEach(() => {
render({ onBlur });
});

afterEach(() => {
onBlur.mockReset();
});

it('is called on blur', () => {
input().simulate('blur');
expect(onBlur).toHaveBeenCalled();
});
});

describe('onChange', () => {
const onChange = jest.fn();

beforeEach(() => {
render({ onChange });
});

afterEach(() => {
onChange.mockReset();
});

it('is called on change', () => {
input().simulate('change', { target: { value: 'text' } });
expect(onChange).toHaveBeenCalled();
});
});

describe('onClick', () => {
const onClick = jest.fn();

beforeEach(() => {
render({ onClick });
});

afterEach(() => {
onClick.mockReset();
});

it('is called on click', () => {
input().simulate('click');
expect(onClick).toHaveBeenCalled();
});
});

describe('onClear', () => {
const onClear = jest.fn();

beforeEach(() => {
render({ onClear });
});

afterEach(() => {
onClear.mockReset();
});

describe('when input has no content', () => {
beforeEach(() => {
input().simulate('change', { target: { value: '' } });
});

it('is called on clear', () => {
button().simulate('click');
expect(onClear).toHaveBeenCalled();
});
});

describe('when input has content', () => {
beforeEach(() => {
input().simulate('change', { target: { value: 'text' } });
});

it('is called on clear', () => {
button().simulate('click');
expect(onClear).toHaveBeenCalled();
});
});
});

describe('onExpand', () => {
const onExpand = jest.fn();

beforeEach(() => {
render({ onExpand });
});

afterEach(() => {
onExpand.mockReset();
});

// This won't work until v11
it.skip('is called on focus', () => {
input().simulate('focus');
expect(onExpand).toHaveBeenCalled();
});
});

describe('onFocus', () => {
const onFocus = jest.fn();

beforeEach(() => {
render({ onFocus });
});

afterEach(() => {
onFocus.mockReset();
});

it('is called on focus', () => {
input().simulate('focus');
expect(onFocus).toHaveBeenCalled();
});
});
});
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,9 @@ import React, { useState, useRef } from 'react';
import classnames from 'classnames';
import Search from '../Search';
import { usePrefix } from '../../internal/usePrefix';
import { composeEventHandlers } from '../../tools/events';

function ExpandableSearch(props) {
function ExpandableSearch({ onBlur, onChange, onExpand, onFocus, ...props }) {
const [expanded, setExpanded] = useState(false);
const [hasContent, setHasContent] = useState(false);
const searchRef = useRef(null);
Expand All @@ -32,6 +33,14 @@ function ExpandableSearch(props) {
}
}

function handleChange(evt) {
setHasContent(evt.target.value !== '');
}

function handleExpand() {
searchRef.current.focus?.();
}

const classes = classnames(
`${prefix}--search--expandable`,
{
Expand All @@ -45,14 +54,10 @@ function ExpandableSearch(props) {
{...props}
ref={searchRef}
className={classes}
onFocus={handleFocus}
onBlur={handleBlur}
onChange={(event) => {
setHasContent(event.target.value !== '');
}}
onExpand={() => {
searchRef.current.focus?.();
}}
onFocus={composeEventHandlers([onFocus, handleFocus])}
onBlur={composeEventHandlers([onBlur, handleBlur])}
onChange={composeEventHandlers([onChange, handleChange])}
onExpand={composeEventHandlers([onExpand, handleExpand])}
/>
);
}
Expand Down
1 change: 1 addition & 0 deletions packages/react/src/components/Search/Search.js
Original file line number Diff line number Diff line change
Expand Up @@ -190,6 +190,7 @@ export default class Search extends Component {
onKeyDown,
renderIcon,
onClear, // eslint-disable-line no-unused-vars
onExpand, // eslint-disable-line no-unused-vars, react/prop-types
...other
} = this.props;

Expand Down
8 changes: 2 additions & 6 deletions packages/react/src/components/Search/next/Search.js
Original file line number Diff line number Diff line change
Expand Up @@ -99,17 +99,13 @@ const Search = React.forwardRef(function Search(

return (
<div role="search" aria-labelledby={searchId} className={searchClasses}>
{/* the magnifier is used in ExpandableSearch as a click target to expand,
{/* the magnifier is used in ExpandableSearch as a click target to expand,
however, it does not need a keyboard event bc the input element gets focus on keyboard nav and expands that way*/}
{/* eslint-disable-next-line jsx-a11y/click-events-have-key-events */}
<div
role={onExpand ? 'button' : null}
className={`${prefix}--search-magnifier`}
onClick={() => {
if (onExpand) {
onExpand();
}
}}>
onClick={onExpand}>
<CustomSearchIcon icon={renderIcon} />
</div>
<label id={searchId} htmlFor={uniqueId} className={`${prefix}--label`}>
Expand Down