Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(pagination): add playground stories for stable and unstable pagination #12441

Merged
merged 4 commits into from
Nov 12, 2022
Merged

chore(pagination): add playground stories for stable and unstable pagination #12441

merged 4 commits into from
Nov 12, 2022

Conversation

alisonjoseph
Copy link
Member

@alisonjoseph alisonjoseph commented Oct 31, 2022

Closes #12272
Closes #12271

Changelog

New

  • playground story for Pagination
  • playground story for unstable_Pagination

Testing / Reviewing

Check playground stories for Pagination and unstable_Pagination

@netlify
Copy link

netlify bot commented Oct 31, 2022

Deploy Preview for carbon-components-react ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 703c045
🔍 Latest deploy log https://app.netlify.com/sites/carbon-components-react/deploys/636f20b0cefa8d000ab05188
😎 Deploy Preview https://deploy-preview-12441--carbon-components-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Oct 31, 2022

Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit 703c045
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/636f20b0abca260009d70a1a
😎 Deploy Preview https://deploy-preview-12441--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@alisonjoseph alisonjoseph marked this pull request as ready for review November 1, 2022 13:30
@alisonjoseph alisonjoseph requested a review from a team as a code owner November 1, 2022 13:30
@alisonjoseph alisonjoseph changed the title 12272 pagination storybook playground chore(pagination): add playground stories for stable and unstable pagination Nov 1, 2022
},
defaultValue: 'false',
},
itemRangeText: {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

itemText also needs control: false

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In both this an the other story as well I think

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch, added!

Copy link
Member

@tay1orjones tay1orjones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor suggestion, but LGTM otherwise!

@aledavila
Copy link
Contributor

Just needs a Percy check. @tay1orjones

@kodiakhq kodiakhq bot merged commit 3d7177e into carbon-design-system:main Nov 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
3 participants