Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Pagination): storybook controls #12604

Closed

Conversation

sstrubberg
Copy link
Member

@sstrubberg sstrubberg commented Nov 11, 2022

Closes #12271

Changelog

  • Updated Pagination MDX for richer docs experience.
  • Removed the knobs import and code from the associated props.
  • Brought the props into the default story for easy copy and paste.
  • Removed the args spreading from the other stories.
  • Created a playground story with all the controls.

Testing / Reviewing

Make sure the Playground works as expected.

@sstrubberg sstrubberg requested a review from a team as a code owner November 11, 2022 16:54
@netlify
Copy link

netlify bot commented Nov 11, 2022

Deploy Preview for carbon-components-react ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 33302de
🔍 Latest deploy log https://app.netlify.com/sites/carbon-components-react/deploys/636e7e58a6a8af0009e843ed
😎 Deploy Preview https://deploy-preview-12604--carbon-components-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Nov 11, 2022

Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit 33302de
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/636e7e58d6847d0008ff653b
😎 Deploy Preview https://deploy-preview-12604--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@sstrubberg
Copy link
Member Author

Closing in favor of #12441

@sstrubberg sstrubberg closed this Nov 15, 2022
@sstrubberg sstrubberg deleted the pagination-controls branch November 16, 2022 03:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Storybook controls: provide /Pagination/next/ playground, controls
2 participants