Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deps): update dependency jscodeshift to ^0.15.0 #13798

Closed
wants to merge 1 commit into from

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented May 15, 2023

Mend Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
jscodeshift ^0.13.1 -> ^0.15.0 age adoption passing confidence

Release Notes

facebook/jscodeshift

v0.15.0

Compare Source

Changed
Fixed

v0.14.0

Compare Source

Added
Changed
  • Bumped dependency versions
  • Allow arguments in --help to be listed in an order other than alphabetically, so they can instead be grouped thematically (#​507, @​elonvolo)
  • Allow the j shortcut in test utils (#​515, @​no23reason)

Configuration

📅 Schedule: Branch creation - "before 3am on Monday" (UTC), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Never, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

@renovate renovate bot requested a review from a team as a code owner May 15, 2023 02:39
@netlify
Copy link

netlify bot commented May 15, 2023

Deploy Preview for carbon-components-react ready!

Name Link
🔨 Latest commit f7256c4
🔍 Latest deploy log https://app.netlify.com/sites/carbon-components-react/deploys/64619b6f781674000839f15a
😎 Deploy Preview https://deploy-preview-13798--carbon-components-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented May 15, 2023

Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit f7256c4
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/64619b6febf6b50008997948
😎 Deploy Preview https://deploy-preview-13798--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@tay1orjones
Copy link
Member

tay1orjones commented May 15, 2023

Tests are failing because of extra parenthesis due to facebook/jscodeshift#534, an upstream bug in recast benjamn/recast#1248

We can update the snapshot, but I'm a bit concerned that downstream consumers using the codemods would get invalid output with extra parens. If those downstream projects don't have an auto formatter like prettier, the transforms could break their code.

@alisonjoseph
Copy link
Member

@tay1orjones should we just close this then and wait to update?

@tay1orjones
Copy link
Member

Yeah in the spirit of keeping our PR queue down, we can close this and renovate should open a new PR when the next version of jscodeshift is released.

@renovate
Copy link
Contributor Author

renovate bot commented May 16, 2023

Renovate Ignore Notification

Because you closed this PR without merging, Renovate will ignore this update (^0.15.0). You will get a PR once a newer version is released. To ignore this dependency forever, add it to the ignoreDeps array of your Renovate config.

If you accidentally closed this PR, or if you changed your mind: rename this PR to get a fresh replacement PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants