Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deps): update dependency jscodeshift to v17 #17264

Merged
merged 14 commits into from
Sep 10, 2024

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Aug 24, 2024

Mend Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
jscodeshift ^0.13.1 -> ^17.0.0 age adoption passing confidence

Warning

Some dependencies could not be looked up. Check the Dependency Dashboard for more information.


Release Notes

facebook/jscodeshift (jscodeshift)

v17.0.0

Compare Source

We needed to go from v0.x to a major release, and it may as well happen now. jscodeshift has been around for nine years though, so going to v1.0.0 didn't feel quite right. I've instead promoted the minor version number to a major version number, similar to what React did when it went from 0.14 to 15.0.

Fixed
  • Node.js 16 is now explicitly specified as the minimum required version. It was already (#​607, @​trivikr)
Added
Changed

v0.16.1

Compare Source

Fixed
  • Removed old babel-core dependency that was unused but caused security scanners to flag vulnerabilities.

v0.16.0

Compare Source

Added
  • Added a --gitignore flag to avoid transforming any files listed in .gitignore (#​508, @​ElonVolo)
Changed

v0.15.2

Compare Source

Fixed

v0.15.1

Compare Source

Changed
Fixed

v0.15.0

Compare Source

Changed
Fixed

v0.14.0

Compare Source

Added
Changed
  • Bumped dependency versions
  • Allow arguments in --help to be listed in an order other than alphabetically, so they can instead be grouped thematically (#​507, @​elonvolo)
  • Allow the j shortcut in test utils (#​515, @​no23reason)

Configuration

📅 Schedule: Branch creation - "after 10pm every weekday,before 5am every weekday,every weekend" (UTC), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Never, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

@renovate renovate bot requested a review from a team as a code owner August 24, 2024 02:25
Copy link

netlify bot commented Aug 24, 2024

Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit edbfaad
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/66e04bfaa0c5940008626930
😎 Deploy Preview https://deploy-preview-17264--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Aug 24, 2024

Deploy Preview for v11-carbon-react ready!

Name Link
🔨 Latest commit edbfaad
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-react/deploys/66e04bfa38089400080c4c9e
😎 Deploy Preview https://deploy-preview-17264--v11-carbon-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@ariellalgilmore
Copy link
Member

this looks to still be blocked - more info at #13798 (comment)

cc: @tay1orjones

Copy link
Contributor Author

renovate bot commented Aug 27, 2024

Edited/Blocked Notification

Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.

You can manually request rebase by checking the rebase/retry box above.

⚠️ Warning: custom changes will be lost.

@guidari guidari added the type: infrastructure 🤖 Issues relating to devops, tech debt, etc. label Aug 28, 2024
@tay1orjones tay1orjones self-assigned this Aug 28, 2024
@tay1orjones
Copy link
Member

@ariellalgilmore Yep! Looks like it. There's an open PR on the upstream recast dep that should fix it all, but in the meantime I think we might just want to deal with having the parens in the output so we can update this and then recommend in the docs that the result be run through an auto-formatter like prettier.

I'll look into this and include it in this PR

Copy link
Member

@tay1orjones tay1orjones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ariellalgilmore @annawen1 this one's ready for review

I've updated this to add the parens to the expected output. Also updated the docs to suggest using an auto formatter in coordination with the codemod output.

@2nikhiltom this will impact #17266 if this is merged first. I'm happy to help update that PR with you if so!

Merged via the queue into main with commit 0dc9eb3 Sep 10, 2024
23 checks passed
@tay1orjones tay1orjones deleted the renovate/jscodeshift-17.x branch September 10, 2024 14:13
Copy link
Contributor

The content of this pull request will be made available as part of our next release. For the full schedule of upcoming releases, check out our Release Radar page.

@carbon-automation
Copy link
Contributor

Hey there! v11.66.0 was just released that references this issue/PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: ready to merge 🎉 type: infrastructure 🤖 Issues relating to devops, tech debt, etc.
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

4 participants